All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Michael Cree <mcree@orcon.net.nz>
Cc: linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] [alpha] Add minimal support for software performance events.
Date: Sun, 8 Nov 2009 13:22:26 +0100	[thread overview]
Message-ID: <20091108122226.GC11372@elte.hu> (raw)
In-Reply-To: <4AE6AAD3.3000102@orcon.net.nz>


* Michael Cree <mcree@orcon.net.nz> wrote:

> > Should be done not by removing the stack-protector build 
> > unconditionally - but by auto-testing whether stackprotector is 
> > supported by GCC and using it if yes.
> 
> Revised patch attached.  It includes a test that the compiler doesn't 
> bomb out with -fstack-protector-all and only adds the option to CFLAGS 
> if ok.  But I have had to put the test below the definition of the 
> macro CC.  This has the side effect of separating the addition of 
> -fstack-protector-all from the main definitions of CFLAGS and 
> ALL_CFLAGS, and is not ideal in my opinion.  The patch also removes 
> -Wcast-align (I forgot to say that in the commit message of the 
> patch).

Nice, i'll queue this up for Linus.

Your S-O-B line was missing from this second patch - i presume you 
intended it to be included, right?

Thanks,

	Ingo

  reply	other threads:[~2009-11-08 12:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26  8:32 [PATCH] [alpha] Add minimal support for software performance events Michael Cree
2009-10-26  8:48 ` Ingo Molnar
2009-10-27  8:09   ` Michael Cree
2009-10-27  8:09     ` Michael Cree
2009-11-08 12:22     ` Ingo Molnar [this message]
2009-11-08 12:27       ` Ingo Molnar
2009-11-11  7:43         ` Michael Cree
2009-11-11  7:43           ` Michael Cree
2009-11-11  7:48           ` [tip:perf/core] perf tools: Test -fstack-protector-all compiler option for inclusion in CFLAGS tip-bot for Michael Cree
2009-10-27 18:29   ` [PATCH] [alpha] Add minimal support for software performance events Matt Turner
2009-10-28 20:56     ` Sam Ravnborg
2009-10-26 11:38 ` [tip:perf/core] perf tools, Alpha: Add Alpha support to perf.h tip-bot for Michael Cree
2009-10-26 12:08   ` Pekka Enberg
2009-10-26 12:22     ` Ingo Molnar
2009-10-28 20:58       ` Sam Ravnborg
2009-11-10 21:21     ` Peter Zijlstra
2009-12-01  4:30 ` [PATCH] [alpha] Add minimal support for software performance events Matt Turner
2009-12-01  9:31   ` Michael Cree
2009-12-01  9:31     ` Michael Cree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091108122226.GC11372@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcree@orcon.net.nz \
    --cc=paulus@samba.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.