From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lennart Poettering Subject: Re: [PATCH 3/3] Define _GNU_SOURCE so that gives O_CLOEXEC Date: Sun, 8 Nov 2009 16:40:17 +0100 Message-ID: <20091108154017.GE25366@tango.0pointer.de> References: <200911052116.53251.remi@remlab.net> <1257448662-5124-3-git-send-email-remi@remlab.net> <20091108144936.GA25366@tango.0pointer.de> <200911081723.37763.remi@remlab.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from tango.0pointer.de (tango.0pointer.de [85.214.72.216]) by alsa0.perex.cz (Postfix) with ESMTP id 90FC31037EA for ; Sun, 8 Nov 2009 16:40:41 +0100 (CET) Content-Disposition: inline In-Reply-To: <200911081723.37763.remi@remlab.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Sun, 08.11.09 17:23, R=E9mi Denis-Courmont (remi@remlab.net) wrote: > = > Le dimanche 8 novembre 2009 16:49:37 Lennart Poettering, vous avez =E9cri= t : > > On Thu, 05.11.09 21:17, R=E9mi Denis-Courmont (remi@remlab.net) wrote: > > > Signed-off-by: R=E9mi Denis-Courmont > > > --- > > > configure.in | 2 ++ > > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > diff --git a/configure.in b/configure.in > > > index a455de1..cc8950f 100644 > > > --- a/configure.in > > > +++ b/configure.in > > > @@ -38,6 +38,8 @@ then > > > AC_MSG_RESULT($CC) > > > fi > > > > > > +CFLAGS=3D"$CFLAGS -D_GNU_SOURCE" > > = > > There's acually an autoconf macro for this. AC_GNU_SOURCE. And even > > better than that is usually AC_SYSTEM_EXTENSIONS. > = > AC_SYSTEM_EXTENSIONS is not much extra help from AC_GNU_SOURCE in a Linux= -only = > library. = In the past there was some work to port it to some BSD iirc, using the OSS backend that is currently in alsa-plugins. Not that I cared a tiny bit about BSD but I generally think that if there are two otherwise equal options one should pick the portable one. But then again, this certainly doesn't matter much. > alsa-lib does not systematically include first, so neither = > of them will work anyway. A nice fix for that could be simply adding -include $(top_builddir)/config.h to AM_CPPFLAGS. A couple of packages do that now, e.g. udev. Lennart -- = Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net http://0pointer.net/lennart/ GnuPG 0x1A015CC4