From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: Graeme Gregory <gg@slimlogic.co.uk>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Grazvydas Ignotas <notasas@gmail.com>,
ext Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH V2] ASoC - Add support for upto 16 channels on OMAP MCBSP
Date: Mon, 9 Nov 2009 10:14:11 +0200 [thread overview]
Message-ID: <20091109101411.12a75af0.jhnikula@gmail.com> (raw)
In-Reply-To: <200911090929.02019.peter.ujfalusi@nokia.com>
On Mon, 9 Nov 2009 09:29:01 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> I think if I set the mcbsp_data->in_freq to be:
> params_rate(params) * sample_bits * channels, and configure the mcbsp_data-
> >clk_div to be 1, might work in this case.
>
I think it's cleanest to calculate frame size conditionally based on
SND_SOC_DAIFMT_CBS_CFS or testing !in_freq and let the frame
size to be wlen * channels in other cases.
If it's based on !in_freq, then the in_freq must be set in
omap_mcbsp_dai_set_dai_sysclk only for OMAP_MCBSP_SYSCLK_xxx cases
since this function is called also when setting CLKR and FSR sources
(no need to pass frequency).
--
Jarkko
prev parent reply other threads:[~2009-11-09 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 21:00 [PATCH V2] ASoC - Add support for upto 16 channels on OMAP MCBSP Liam Girdwood
2009-11-06 18:24 ` Jarkko Nikula
2009-11-07 20:11 ` Grazvydas Ignotas
2009-11-08 20:27 ` Liam Girdwood
2009-11-09 6:57 ` Jarkko Nikula
2009-11-09 7:24 ` Peter Ujfalusi
2009-11-09 6:57 ` Peter Ujfalusi
2009-11-09 7:29 ` Peter Ujfalusi
2009-11-09 7:47 ` Jarkko Nikula
2009-11-09 8:14 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109101411.12a75af0.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=lrg@slimlogic.co.uk \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.