From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N7bRZ-0004n5-Qy for mharc-grub-devel@gnu.org; Mon, 09 Nov 2009 16:06:33 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7bRU-0004iE-8V for grub-devel@gnu.org; Mon, 09 Nov 2009 16:06:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7bRO-0004dF-7j for grub-devel@gnu.org; Mon, 09 Nov 2009 16:06:27 -0500 Received: from [199.232.76.173] (port=46445 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7bRO-0004dC-02 for grub-devel@gnu.org; Mon, 09 Nov 2009 16:06:22 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:38714 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N7bRN-0005ot-8t for grub-devel@gnu.org; Mon, 09 Nov 2009 16:06:21 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1N7bRK-0001ZL-PS; Mon, 09 Nov 2009 22:06:19 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1N7bRK-0004b3-9L; Mon, 09 Nov 2009 22:06:18 +0100 Date: Mon, 9 Nov 2009 22:06:18 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091109210618.GA17646@thorin> References: <4AF6FB4D.8030501@t-online.de> <20091109141338.GB19358@thorin> <20091109150017.GA13079@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091109150017.GA13079@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Vladimir Serbinenko Subject: Re: [PATCH] prefix redefinition fix (Re: hdparm documentation) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2009 21:06:28 -0000 On Mon, Nov 09, 2009 at 04:00:17PM +0100, Robert Millan wrote: > === modified file 'normal/autofs.c' > --- normal/autofs.c 2009-11-09 14:45:28 +0000 > +++ normal/autofs.c 2009-11-09 14:55:27 +0000 > @@ -51,12 +51,6 @@ > read_fs_list (void) > { > const char *prefix; > - static int first_time = 1; > - > - /* Make sure that this function does not get executed twice. */ > - if (! first_time) > - return; > - first_time = 0; > > prefix = grub_env_get ("prefix"); > if (prefix) > @@ -72,6 +66,15 @@ > file = grub_file_open (filename); Vladimir, I don't think grub_file_open() can cause read_fs_list() to be invoked recursively. Note that read_fs_list() is not called when probing for filesystems, only during initialization (before my patch, only once, and after my patch, additionally each time ${prefix} is written to). Do you still see a problem with this patch? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."