From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Steven Rostedt <rostedt@goodmis.org>,
Li Zefan <lizf@cn.fujitsu.com>, Jason Baron <jbaron@redhat.com>
Subject: Re: [PATCH v2] tracing: Protect the buffer from recursion in perf
Date: Tue, 10 Nov 2009 11:40:04 +0100 [thread overview]
Message-ID: <20091110104002.GE5255@nowhere> (raw)
In-Reply-To: <1257848862.4648.33.camel@twins>
On Tue, Nov 10, 2009 at 11:27:42AM +0100, Peter Zijlstra wrote:
> There already is recursion protection in
> kernel/perf_event.c:perf_swevent_recursion_context() and thereabouts.
> Could you not fix this by widening its scope?
Hmm, indeed.
I could probably use perf_swevent_recursion_context() directly from
the tracing fill path. And then split up a bit do_perf_sw_event()
so that it continues to check the recursion for normal software events
but not for trace events (for which we would already explicitly
call perf_swevent_recursion_context()).
I'll try that, thanks!
prev parent reply other threads:[~2009-11-10 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 22:23 [PATCH] tracing: Protect the buffer from recursion in perf Frederic Weisbecker
2009-11-05 3:06 ` Masami Hiramatsu
2009-11-06 3:13 ` [PATCH v2] " Frederic Weisbecker
2009-11-08 9:40 ` [tip:perf/probes] tracing, perf_events: " tip-bot for Frederic Weisbecker
2009-11-10 10:27 ` [PATCH v2] tracing: " Peter Zijlstra
2009-11-10 10:40 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110104002.GE5255@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.