All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, dimm <dmitry.adamushko@gmail.com>
Subject: [PATCH 2/3] x86, ucode-amd: Don't warn when no ucode is available for a CPU revision
Date: Tue, 10 Nov 2009 12:08:25 +0100	[thread overview]
Message-ID: <20091110110825.GI30802@alberich.amd.com> (raw)
In-Reply-To: <20091110110601.GG30802@alberich.amd.com>

There is no point in warning when there is no ucode available for a
specific CPU revision. Currently the container-file, which provides the
AMD ucode patches for OS load, contains only a few ucode patches.

It's already clearly indicated by the printed patch_level whenever new
ucode was available and an update happened. So the warning message is
of no help but rather annoying on systems with many CPUs.

Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
 arch/x86/kernel/microcode_amd.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
index 75538f6..9f13324 100644
--- a/arch/x86/kernel/microcode_amd.c
+++ b/arch/x86/kernel/microcode_amd.c
@@ -105,11 +105,8 @@ static int get_matching_microcode(int cpu, void *mc, int rev)
 		i++;
 	}
 
-	if (!equiv_cpu_id) {
-		printk(KERN_WARNING "microcode: CPU%d: cpu revision "
-		       "not listed in equivalent cpu table\n", cpu);
+	if (!equiv_cpu_id)
 		return 0;
-	}
 
 	if (mc_header->processor_rev_id != equiv_cpu_id)
 		return 0;
-- 
1.6.5.2


  parent reply	other threads:[~2009-11-10 11:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 11:06 [PATCH 0/3] x86, ucode-amd: trim verbosity Andreas Herrmann
2009-11-10 11:07 ` [PATCH 1/3] x86, ucode-amd: Load ucode-patches once and not separately fo each CPU Andreas Herrmann
2009-11-10 12:02   ` Dmitry Adamushko
2009-11-11  7:51     ` Clemens Ladisch
2009-11-11 11:27       ` Andreas Herrmann
2009-11-12 15:05     ` Andreas Herrmann
2009-11-10 13:21   ` [tip:x86/microcode] x86: ucode-amd: Load ucode-patches once and not separately of " tip-bot for Andreas Herrmann
2009-11-10 11:08 ` Andreas Herrmann [this message]
2009-11-10 13:22   ` [tip:x86/microcode] x86: ucode-amd: Don't warn when no ucode is available for a CPU revision tip-bot for Andreas Herrmann
2009-11-10 11:09 ` [PATCH 3/3] x86, ucode-amd: printk(KERN_* to pr_* conversion Andreas Herrmann
2009-11-10 13:22   ` [tip:x86/microcode] x86: ucode-amd: Convert printk(KERN_*...) to pr_*(...) tip-bot for Andreas Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091110110825.GI30802@alberich.amd.com \
    --to=herrmann.der.user@googlemail.com \
    --cc=dmitry.adamushko@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.