Re: [PATCH 1/2] sanitize xattr handler prototypes

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 03 Nov 2009 17:11:47 +0000
Steven Whitehouse <swhiteho@redhat.com> wrote:

> Hi,
> 
> On Tue, 2009-11-03 at 16:44 +0100, Christoph Hellwig wrote:
> > Add a flags argument to strcut xattr_handler and pass it to all xattr           
> > handler methods.  This allows using the same methods for multiple               
> > handlers, e.g. for the ACL methods which perform exactly the same action        
> > for the access and default ACLs, just using a different underlying              
> > attribute.  With a little more groundwork it'll also allow sharing the          
> > methods for the regular user/trusted/secure handlers in extN, ocfs2 and         
> > jffs2 like it's already done for xfs in this patch.
> > 
> > Also change the inode argument to the handlers to a dentry to allow             
> > using the handlers mechnism for filesystems that require it later,              
> > e.g. cifs. 
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>                                   
> > Reviewed-by: James Morris <jmorris@namei.org>
> > Acked-by: Joel Becker <joel.becker@oracle.com>
> > 
> GFS2 bits Acked-by: Steven Whitehouse <swhiteho@redhat.com>
> 

GFS2 bits Buggered-up-by: Steven Whitehouse <swhiteho@redhat.com>

patching file fs/gfs2/acl.c
Hunk #1 FAILED at 185.
Hunk #2 FAILED at 196.
Hunk #3 FAILED at 205.
Hunk #4 FAILED at 217.
Hunk #5 FAILED at 231.
5 out of 5 hunks FAILED -- saving rejects to file fs/gfs2/acl.c.rej
patching file fs/gfs2/inode.c
patching file fs/gfs2/xattr.c
Hunk #1 succeeded at 567 (offset 30 lines).
Hunk #2 succeeded at 1118 (offset 30 lines).
Hunk #3 succeeded at 1129 (offset 30 lines).
Hunk #4 succeeded at 1154 (offset 30 lines).
Hunk #5 succeeded at 1182 (offset 30 lines).
Hunk #6 succeeded at 1222 (offset 30 lines).
Hunk #7 FAILED at 1530.
1 out of 7 hunks FAILED -- saving rejects to file fs/gfs2/xattr.c.rej

linux-next changes have made rather a mess of this patch.