All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domenico Andreoli <cavokz@gmail.com>
To: Roman Gaufman <hackeron@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: tw68-v2/tw68-i2c.c:145: error: unknown field ???client_register??? specified in initializer
Date: Tue, 10 Nov 2009 18:30:44 +0100	[thread overview]
Message-ID: <20091110173044.GA7332@raptus.dandreoli.com> (raw)
In-Reply-To: <921ad39e0911100851m3ebd34et5c059838109f66@mail.gmail.com>

On Tue, Nov 10, 2009 at 04:51:47PM +0000, Roman Gaufman wrote:
> 2009/11/10 Domenico Andreoli <cavokz@gmail.com>:
> > On Tue, Nov 10, 2009 at 01:48:43PM +0000, Roman Gaufman wrote:
> >> I swapped my graphics card and techwell DVR card places and now it
> >> works, thanks you!!!
> >
> > have you a PCI-E techwell board?
> 
> Yep, it's PCI-E 8 audio/video dvr card.

there are a lot of cheap boards based on these chips on ebay

> > i'm taking the driver out of the freezer trying to get rid of
> > the IRQF_DISABLED warning flag. i'm interested in seeing your
> > /proc/interrupts, if possible, before and after the boards swap.
> 
> Both with the patch:
> 
> After the swap (working):
> 
>            CPU0       CPU1       CPU2       CPU3
>   0:         22          0          0         40   IO-APIC-edge      timer
>   1:          0          0          0          2   IO-APIC-edge      i8042
>   4:          0          0          0          2   IO-APIC-edge
>   8:          0          0          0          1   IO-APIC-edge      rtc0
>   9:          0          0          0          0   IO-APIC-fasteoi   acpi
>  16:          0          0          0     543773   IO-APIC-fasteoi   ahci, uhci_hcd:usb3, uhci_hcd:usb9, tw6804[0], tw6804[4]
>  17:          0          0          0      40297   IO-APIC-fasteoi   pata_jmicron, ohci1394, tw6804[1], tw6804[5]
>  18:          0          0          0      24680   IO-APIC-fasteoi   ehci_hcd:usb1, uhci_hcd:usb5, uhci_hcd:usb8, tw6804[2], tw6804[6]
>  19:          0          0      40184          0   IO-APIC-fasteoi   uhci_hcd:usb7, tw6804[3], tw6804[7]
>  21:          0          0          0          0   IO-APIC-fasteoi   uhci_hcd:usb4
>  22:          0        218          0          0   IO-APIC-fasteoi   HDA Intel
>  23:          0          0          0        108   IO-APIC-fasteoi   ehci_hcd:usb2, uhci_hcd:usb6
>  24:     934040          0          0          0  HPET_MSI-edge      hpet2
>  25:          0     390326          0          0  HPET_MSI-edge      hpet3
>  26:          0          0     590635          0  HPET_MSI-edge      hpet4
>  27:          0          0          0     845999  HPET_MSI-edge      hpet5
>  33:          0          0          0          0   PCI-MSI-edge      ahci
>  34:     812442          0          0          0   PCI-MSI-edge      eth1
> NMI:          0          0          0          0   Non-maskable interrupts
> LOC:         54         38         23          8   Local timer interrupts
> SPU:          0          0          0          0   Spurious interrupts
> CNT:          0          0          0          0   Performance counter interrupts
> PND:          0          0          0          0   Performance pending work
> RES:       4027       5400       6102       6462   Rescheduling interrupts
> CAL:        124        139        137         44   Function call interrupts
> TLB:      27517      22022      23155      17498   TLB shootdowns
> TRM:          0          0          0          0   Thermal event interrupts
> THR:          0          0          0          0   Threshold APIC interrupts
> MCE:          0          0          0          0   Machine check exceptions
> MCP:         41         41         41         41   Machine check polls
> ERR:          0
> MIS:          0
> 
> Before swap (system freezes as soon as I try to open video device):
> 
> # cat /proc/interrupts
>            CPU0       CPU1       CPU2       CPU3
>   0:         22          0          0          1   IO-APIC-edge      timer
>   1:          0          0          0          2   IO-APIC-edge      i8042
>   4:          0          0          0          2   IO-APIC-edge
>   8:          0          0          0          1   IO-APIC-edge      rtc0
>   9:          0          0          0          0   IO-APIC-fasteoi   acpi
>  16:          0          0          0       9090   IO-APIC-fasteoi   ahci, uhci_hcd:usb3, uhci_hcd:usb9, tw6804[0], tw6804[4]
>  17:          0          0          0          3   IO-APIC-fasteoi   pata_jmicron, ohci1394, tw6804[1], tw6804[5]
>  18:          0          0          0          0   IO-APIC-fasteoi   ehci_hcd:usb1, uhci_hcd:usb5, uhci_hcd:usb8, tw6804[2], tw6804[6]
>  19:          0          0          0          0   IO-APIC-fasteoi   uhci_hcd:usb7, tw6804[3], tw6804[7]
>  21:          0          0          0          0   IO-APIC-fasteoi   uhci_hcd:usb4
>  22:          0        218          0          0   IO-APIC-fasteoi   HDA Intel
>  23:          0          0          0        103   IO-APIC-fasteoi   ehci_hcd:usb2, uhci_hcd:usb6
>  24:       3102          0          0          0  HPET_MSI-edge      hpet2
>  25:          0       2403          0          0  HPET_MSI-edge      hpet3
>  26:          0          0       1899          0  HPET_MSI-edge      hpet4
>  27:          0          0          0       2835  HPET_MSI-edge      hpet5
>  33:          0          0          0          0   PCI-MSI-edge      ahci
>  34:        816          0          0          0   PCI-MSI-edge      eth1
> NMI:          0          0          0          0   Non-maskable interrupts
> LOC:         54         38         23          8   Local timer interrupts
> SPU:          0          0          0          0   Spurious interrupts
> CNT:          0          0          0          0   Performance counter interrupts
> PND:          0          0          0          0   Performance pending work
> RES:          8          7          6          7   Rescheduling interrupts
> CAL:        118        130        129         46   Function call interrupts
> TLB:        970        879        706        739   TLB shootdowns
> TRM:          0          0          0          0   Thermal event interrupts
> THR:          0          0          0          0   Threshold APIC interrupts
> MCE:          0          0          0          0   Machine check exceptions
> MCP:          2          2          2          2   Machine check polls
> ERR:          0
> MIS:          0

they are identical. where is the graphic controller here? i expected
to see it sharing an irq with some tw68 device, at least before the swap.

i forgot to say that simply removing the IRQF_DISABLED flag makes the
warning go away but may introduce some error with shared irq handling.

> >> Only 1 question, the readme says there is no audio yet - any ideas
> >> when/if audio will be available? :)
> >
> > bad news here, i can't promise anything. anyway i'd like to push this
> > driver to kernel staging and audio support is required for this step. so
> > it is one of my topmost TODO entries.
> 
> Heh, fair enough - thank you for working on this!

actually i did not write a line of code of this driver, it's all by
William Brack. i only have a different implementation never published.

regards,
Domenico

-----[ Domenico Andreoli, aka cavok
 --[ http://www.dandreoli.com/gpgkey.asc
   ---[ 3A0F 2F80 F79C 678A 8936  4FEE 0677 9033 A20E BC50

  reply	other threads:[~2009-11-10 17:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 12:19 tw68-v2/tw68-i2c.c:145: error: unknown field ‘client_register’ specified in initializer Roman Gaufman
2009-11-10 12:26 ` Domenico Andreoli
2009-11-10 12:40   ` Roman Gaufman
2009-11-10 12:50     ` Domenico Andreoli
2009-11-10 13:16       ` Roman Gaufman
2009-11-10 13:48         ` Roman Gaufman
2009-11-10 15:03           ` tw68-v2/tw68-i2c.c:145: error: unknown field ???client_register??? " Domenico Andreoli
2009-11-10 16:51             ` Roman Gaufman
2009-11-10 17:30               ` Domenico Andreoli [this message]
2009-11-10 15:28           ` Domenico Andreoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091110173044.GA7332@raptus.dandreoli.com \
    --to=cavokz@gmail.com \
    --cc=hackeron@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.