From: Josh Triplett <josh@joshtriplett.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com
Subject: Re: [PATCH tip/core/rcu 1/4] rcu: remove inline from forward-referenced functions
Date: Tue, 10 Nov 2009 15:03:00 -0800 [thread overview]
Message-ID: <20091110230259.GA14679@feather> (raw)
In-Reply-To: <12578890422402-git-send-email->
On Tue, Nov 10, 2009 at 01:37:19PM -0800, Paul E. McKenney wrote:
> Some variants of gcc are reputed to dislike forward references to
> functions declared "inline". Remove the "inline" keyword from such
> functions.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
> kernel/rcutree.h | 2 +-
> kernel/rcutree_plugin.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Seems very reasonable. For functions declared static and called once, GCC doesn't
really need any help figuring out that it should inline them.
Acked-by: Josh Triplett <josh@joshtriplett.org>
next prev parent reply other threads:[~2009-11-10 23:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 21:36 [PATCH tip/core/rcu 0/4] rcu inline, expedited, ->completed cleanups Paul E. McKenney
2009-11-10 21:37 ` [PATCH tip/core/rcu 1/4] rcu: remove inline from forward-referenced functions Paul E. McKenney
2009-11-10 22:27 ` [tip:core/rcu] rcu: Remove " tip-bot for Paul E. McKenney
2009-11-10 22:38 ` Joe Perches
2009-11-10 22:59 ` Paul E. McKenney
2009-11-10 23:06 ` Joe Perches
2009-11-10 23:41 ` Paul E. McKenney
2009-11-11 1:03 ` Joe Perches
2009-11-11 1:42 ` Paul E. McKenney
2009-11-11 3:28 ` Joe Perches
2009-11-11 4:50 ` Paul E. McKenney
2009-11-11 5:41 ` Paul E. McKenney
2009-11-11 7:02 ` Ingo Molnar
2009-11-11 19:47 ` Paul E. McKenney
2009-11-10 23:03 ` Josh Triplett [this message]
2009-11-10 21:37 ` [PATCH tip/core/rcu 2/4] rcu: enable synchronize_sched_expedited() fastpath Paul E. McKenney
2009-11-10 22:27 ` [tip:core/rcu] rcu: Enable " tip-bot for Paul E. McKenney
2009-11-10 21:37 ` [PATCH tip/core/rcu 3/4] rcu: rename dynticks_completed to completed_fqs Paul E. McKenney
2009-11-10 22:28 ` [tip:core/rcu] rcu: Rename " tip-bot for Paul E. McKenney
2009-11-10 21:37 ` [PATCH tip/core/rcu 4/4] rcu: simplify association of quiescent states with grace periods Paul E. McKenney
2009-11-10 22:28 ` [tip:core/rcu] rcu: Simplify " tip-bot for Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110230259.GA14679@feather \
--to=josh@joshtriplett.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.