diff for duplicates of <20091111101159.72ad3014@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 0e031e8..ccda411 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,22 +3,25 @@ On 2009-11-11 Patroklos Argyroudis wrote: > > Why wouldn't you bump the size of the buffer by two as well? > > Otherwise valid universal addresses that are RPCBIND_MAXUADDRLEN > > bytes long will fail here. -> >=20 +> > > > > memcpy(buf, uaddr, uaddr_len); ->=20 +> > There is no need to increase the size of the buffer since the new > check (if (uaddr_len > sizeof(buf) - 2)) will terminate the function > in case the valid universal address is RPCBIND_MAXUADDRLEN bytes. -=46ailing to convert a valid address is incorrect and unexpected. What +Failing to convert a valid address is incorrect and unexpected. What Chuck meant is that since it is valid to have an address up to RPCBIND_MAXUADDRLEN bytes long, the function should be able to work on that, by having an internal buffer that allows for the extra "\n\0". Cheers, -=46=C3=A1bio Oliv=C3=A9 ---=20 +Fábio Olivé +-- ex sed lex awk yacc, e pluribus unix, amem -na matem=C3=A1tica das id=C3=A9ias, permuta =C3=A9 igual a adi=C3=A7=C3= -=A3o -e um debate inteligente implementa a multiplica=C3=A7=C3=A3o +na matemática das idéias, permuta é igual a adição +e um debate inteligente implementa a multiplicação +-- +To unsubscribe from this list: send the line "unsubscribe linux-nfs" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 4f7d0cd..6a4a1c5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,19 +2,19 @@ "ref\020091110152908.7558a471.akpm@linux-foundation.org\0" "ref\0967DC2CE-588D-4207-BF2D-59727454DC2E@oracle.com\0" "ref\020091111075128.GA28323@evola\0" - "From\0Fabio Olive Leite <fabio.olive@gmail.com>\0" + "From\0Fabio Olive Leite <fabio.olive-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" "Subject\0Re: [Bugme-new] [Bug 14546] New: Off-by-two stack buffer overflow in function rpc_uaddr2sockaddr() of net/sunrpc/addr.c\0" "Date\0Wed, 11 Nov 2009 10:11:59 -0200\0" "To\0Patroklos Argyroudis <argp-YZAGAMbGdGKGw+nKnLezzg@public.gmane.org>\0" - "Cc\0Chuck Lever <chuck.lever@oracle.com>" + "Cc\0Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>" bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org bugme-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org - Linux Network Developers <netdev@vger.kernel.org> - J. Bruce Fields <bfields@fieldses.org> - Trond Myklebust <trond.myklebust@fys.uio.no> - Neil Brown <neilb@suse.de> - Andrew Morton <akpm@linux-foundation.org> - " Linux NFS Mailing list <linux-nfs@vger.kernel.org>\0" + Linux Network Developers <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + J. Bruce Fields <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> + Trond Myklebust <trond.myklebust-41N18TsMXrtuMpJDpNschA@public.gmane.org> + Neil Brown <neilb-l3A5Bk7waGM@public.gmane.org> + Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> + " Linux NFS Mailing list <linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" "\00:1\0" "b\0" "On 2009-11-11 Patroklos Argyroudis wrote:\n" @@ -22,24 +22,27 @@ "> > Why wouldn't you bump the size of the buffer by two as well?\n" "> > Otherwise valid universal addresses that are RPCBIND_MAXUADDRLEN\n" "> > bytes long will fail here.\n" - "> >=20\n" + "> > \n" "> > >\tmemcpy(buf, uaddr, uaddr_len);\n" - ">=20\n" + "> \n" "> There is no need to increase the size of the buffer since the new\n" "> check (if (uaddr_len > sizeof(buf) - 2)) will terminate the function\n" "> in case the valid universal address is RPCBIND_MAXUADDRLEN bytes.\n" "\n" - "=46ailing to convert a valid address is incorrect and unexpected. What\n" + "Failing to convert a valid address is incorrect and unexpected. What\n" "Chuck meant is that since it is valid to have an address up to\n" "RPCBIND_MAXUADDRLEN bytes long, the function should be able to work on\n" "that, by having an internal buffer that allows for the extra \"\\n\\0\".\n" "\n" "Cheers,\n" - "=46=C3=A1bio Oliv=C3=A9\n" - "--=20\n" + "F\303\241bio Oliv\303\251\n" + "-- \n" "ex sed lex awk yacc, e pluribus unix, amem\n" - "na matem=C3=A1tica das id=C3=A9ias, permuta =C3=A9 igual a adi=C3=A7=C3=\n" - "=A3o\n" - e um debate inteligente implementa a multiplica=C3=A7=C3=A3o + "na matem\303\241tica das id\303\251ias, permuta \303\251 igual a adi\303\247\303\243o\n" + "e um debate inteligente implementa a multiplica\303\247\303\243o\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-nfs\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -e808143155689a9b7afdffcec5378e8c57bb0477e33a94550a94232fe9ee7d56 +37edaba71af5ab4d86b5994856766ae4dc36c3e2eddb305a937f94b86527debb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.