diff for duplicates of <200911111254.16500.florian@openwrt.org> diff --git a/a/1.txt b/N1/1.txt index 6cad17f..73174ca 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -32,28 +32,3 @@ wrote: > aup->mac_id needs to be 1 for this loop to be executed in the first > place, and here > you immediately bail out if it is. - -From the reading of the comment, it seems to me like we should not do anything -in this for loop if we were using MAC1, but I may have misunderstood that, as -such I have added this break to "comply" with the comment. - -> Also, how do you access the phy map of the other controller without use of -> the au_macs[] structure? (which is unused after this patch and could be -> removed, along -> with the NUM_ETH_INTERFACES constant) - -We access the phy map of the other controller by using the correct mii bus -identifier, since we have registered a per-interface mdio bus or have I -overlooked something ? - -> -> > + struct phy_device *const -> > tmp_phydev = + -> > aup->mii_bus->phy_map[phy_addr]; -> -> My compiler complains about mixed code/declarations. - -That declaration was already there and as this patch has no intent to clean -anything right now, I have left it as-is. --- -Florian diff --git a/a/content_digest b/N1/content_digest index b7f636e..d59c149 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -43,31 +43,6 @@ "> \n" "> aup->mac_id needs to be 1 for this loop to be executed in the first\n" "> place, and here\n" - "> you immediately bail out if it is.\n" - "\n" - "From the reading of the comment, it seems to me like we should not do anything \n" - "in this for loop if we were using MAC1, but I may have misunderstood that, as \n" - "such I have added this break to \"comply\" with the comment.\n" - "\n" - "> Also, how do you access the phy map of the other controller without use of\n" - "> the au_macs[] structure? (which is unused after this patch and could be\n" - "> removed, along\n" - "> with the NUM_ETH_INTERFACES constant)\n" - "\n" - "We access the phy map of the other controller by using the correct mii bus \n" - "identifier, since we have registered a per-interface mdio bus or have I \n" - "overlooked something ?\n" - "\n" - "> \n" - "> > + struct phy_device *const\n" - "> > tmp_phydev = + \n" - "> > aup->mii_bus->phy_map[phy_addr];\n" - "> \n" - "> My compiler complains about mixed code/declarations.\n" - "\n" - "That declaration was already there and as this patch has no intent to clean \n" - "anything right now, I have left it as-is.\n" - "--\n" - Florian + > you immediately bail out if it is. -dfeddc3dfebddb30d7e7dead3e9ea6d03408cc417fb81497b28fce632fcb313f +649fb5fe4b113aa452d1a8872f7e19f4325eb8c985c129fc3e7e4cf13369a376
diff --git a/a/1.txt b/N2/1.txt index 6cad17f..05edc23 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -33,7 +33,7 @@ wrote: > place, and here > you immediately bail out if it is. -From the reading of the comment, it seems to me like we should not do anything +>From the reading of the comment, it seems to me like we should not do anything in this for loop if we were using MAC1, but I may have misunderstood that, as such I have added this break to "comply" with the comment. diff --git a/a/content_digest b/N2/content_digest index b7f636e..300fd65 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -45,7 +45,7 @@ "> place, and here\n" "> you immediately bail out if it is.\n" "\n" - "From the reading of the comment, it seems to me like we should not do anything \n" + ">From the reading of the comment, it seems to me like we should not do anything \n" "in this for loop if we were using MAC1, but I may have misunderstood that, as \n" "such I have added this break to \"comply\" with the comment.\n" "\n" @@ -70,4 +70,4 @@ "--\n" Florian -dfeddc3dfebddb30d7e7dead3e9ea6d03408cc417fb81497b28fce632fcb313f +845b81cd4025ed98334162f435847b9f3b97179956e1c0a234c9429dd7adbb8d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.