All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
	Ralf Baechle <ralf@linux-mips.org>,
	Linus Walleij <linus.walleij@stericsson.com>,
	John Stultz <johnstul@us.ibm.com>, Ingo Molnar <mingo@elte.hu>
Subject: [patch 3/3] mips: Use generic mult/shift factor calculation for clocks
Date: Wed, 11 Nov 2009 14:05:34 -0000	[thread overview]
Message-ID: <20091111134229.807255074@linutronix.de> (raw)
In-Reply-To: 20091111134018.393422332@linutronix.de

[-- Attachment #1: mips-use-generic-shift-mult-calculation.patch --]
[-- Type: text/plain, Size: 2591 bytes --]

Replace the MIPS functions of mult/shift factor calculation for clock
events and clock sources with inline functions which call the generic
functions. The minimum guaranteed conversion range is set to 4 seconds
which corresponds to the current MIPS implementation.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Mikael Pettersson <mikpe@it.uu.se>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Linus Walleij <linus.walleij@stericsson.com>
Cc: John Stultz <johnstul@us.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
---
 arch/mips/include/asm/time.h |   14 +++++++++++---
 arch/mips/kernel/time.c      |   33 ---------------------------------
 2 files changed, 11 insertions(+), 36 deletions(-)

Index: linux-2.6-tip/arch/mips/include/asm/time.h
===================================================================
--- linux-2.6-tip.orig/arch/mips/include/asm/time.h
+++ linux-2.6-tip/arch/mips/include/asm/time.h
@@ -84,8 +84,16 @@ static inline int init_mips_clocksource(
 #endif
 }
 
-extern void clocksource_set_clock(struct clocksource *cs, unsigned int clock);
-extern void clockevent_set_clock(struct clock_event_device *cd,
-		unsigned int clock);
+static inline void clocksource_set_clock(struct clocksource *cs,
+					 unsigned int clock)
+{
+	clocksource_calc_mult_shift(cs, clock, 4);
+}
+
+static inline void clockevent_set_clock(struct clock_event_device *cd,
+					unsigned int clock)
+{
+	clockevents_calc_mult_shift(cd, clock, 4);
+}
 
 #endif /* _ASM_TIME_H */
Index: linux-2.6-tip/arch/mips/kernel/time.c
===================================================================
--- linux-2.6-tip.orig/arch/mips/kernel/time.c
+++ linux-2.6-tip/arch/mips/kernel/time.c
@@ -71,39 +71,6 @@ EXPORT_SYMBOL(perf_irq);
 
 unsigned int mips_hpt_frequency;
 
-void __init clocksource_set_clock(struct clocksource *cs, unsigned int clock)
-{
-	u64 temp;
-	u32 shift;
-
-	/* Find a shift value */
-	for (shift = 32; shift > 0; shift--) {
-		temp = (u64) NSEC_PER_SEC << shift;
-		do_div(temp, clock);
-		if ((temp >> 32) == 0)
-			break;
-	}
-	cs->shift = shift;
-	cs->mult = (u32) temp;
-}
-
-void __cpuinit clockevent_set_clock(struct clock_event_device *cd,
-	unsigned int clock)
-{
-	u64 temp;
-	u32 shift;
-
-	/* Find a shift value */
-	for (shift = 32; shift > 0; shift--) {
-		temp = (u64) clock << shift;
-		do_div(temp, NSEC_PER_SEC);
-		if ((temp >> 32) == 0)
-			break;
-	}
-	cd->shift = shift;
-	cd->mult = (u32) temp;
-}
-
 /*
  * This function exists in order to cause an error due to a duplicate
  * definition if platform code should have its own implementation.  The hook



  parent reply	other threads:[~2009-11-11 14:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11 14:05 [patch 0/3] Provide generic function to calc mult/shift factors for clocks Thomas Gleixner
2009-11-11 14:05 ` [patch 1/3] clockevents: Use u32 for mult and shift factors Thomas Gleixner
2009-11-13 19:48   ` [tip:timers/core] " tip-bot for Thomas Gleixner
2009-11-11 14:05 ` [patch 2/3] clocksource: Provide a generic mult/shift factor calculation Thomas Gleixner
2009-11-13 19:49   ` [tip:timers/core] " tip-bot for Thomas Gleixner
2009-11-11 14:05 ` Thomas Gleixner [this message]
2009-11-13 19:49   ` [tip:timers/core] mips: Use generic mult/shift factor calculation for clocks tip-bot for Thomas Gleixner
2009-11-11 14:08 ` [patch 0/3] Provide generic function to calc mult/shift factors forclocks Linus Walleij
2009-11-12 11:37 ` [patch 0/3] Provide generic function to calc mult/shift factors for clocks Ralf Baechle
2009-11-12 16:59 ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111134229.807255074@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=johnstul@us.ibm.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=mingo@elte.hu \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.