From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments
Date: Wed, 11 Nov 2009 16:34:49 +0200 [thread overview]
Message-ID: <20091111143449.GA30065@redhat.com> (raw)
In-Reply-To: <200911111416.00355.paul@codesourcery.com>
On Wed, Nov 11, 2009 at 02:16:00PM +0000, Paul Brook wrote:
> On Wednesday 11 November 2009, Michael S. Tsirkin wrote:
> > On Wed, Nov 11, 2009 at 01:45:35PM +0000, Paul Brook wrote:
> > > If you don't need real barriers, then why does the kvm code have them?
> >
> > We need real barriers but AFAIK kvm does not have them :(
> > IOW: virtio is currently broken with kvm, and my patch did
> > not fix this. The comment that I added says as much.
>
> So your code just makes the bug harder to reproduce? Doesn't sound like a good
> thing to me.
>
> Paul
There are multiple bugs, I can't fix all of them,
for all architectures, in one patch.
--
MST
next prev parent reply other threads:[~2009-11-11 14:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 13:17 [Qemu-devel] [PATCH] qemu/virtio: make wmb compiler barrier + comments Michael S. Tsirkin
2009-11-11 1:34 ` Paul Brook
2009-11-11 9:37 ` [Qemu-devel] " Michael S. Tsirkin
2009-11-11 13:01 ` Paul Brook
2009-11-11 13:12 ` Michael S. Tsirkin
2009-11-11 13:45 ` Paul Brook
2009-11-11 14:08 ` Michael S. Tsirkin
2009-11-11 14:16 ` Paul Brook
2009-11-11 14:34 ` Michael S. Tsirkin [this message]
2009-11-11 16:13 ` Paul Brook
2009-11-11 17:18 ` Scott Tsai
2009-11-11 18:08 ` Michael S. Tsirkin
2009-11-11 18:09 ` Michael S. Tsirkin
2009-11-11 18:37 ` Scott Tsai
2009-11-11 19:56 ` Michael S. Tsirkin
2009-11-13 3:00 ` Jamie Lokier
2009-11-11 13:15 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111143449.GA30065@redhat.com \
--to=mst@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.