From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Brian Swetland <swetland@google.com>,
Arve Hj?nnev?g <arve@android.com>,
linux-fbdev-devel@lists.sourceforge.net,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: drivers/video/msm: update to new kernel
Date: Thu, 12 Nov 2009 11:19:02 +0100 [thread overview]
Message-ID: <20091112101902.GA11980@elf.ucw.cz> (raw)
In-Reply-To: <20091103161733.970b885f.akpm@linux-foundation.org>
On Tue 2009-11-03 16:17:33, Andrew Morton wrote:
> On Thu, 22 Oct 2009 10:56:39 +0200
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > TASK_INTERRUPTIBLE and friends are now only available after including
> > <linux/sched.h>, so include it when needed.
> >
> > bus_id is no longer available/neccessary, so remove that.
> >
> > Android pmem driver is not available in mainline, so remove its hooks
> > from drivers/video.
> >
>
> What is the impact of these changes?
>
> #2 looks like it's a build fix. #3 looks like it isn't a build fix.
> #1 is a mystery.
Well, it now compiles. #1... I guess something changed in arm headers
and explicit include of <linux/sched.h> became neccessary. #3 not all
usages of pmem were protected with #ifdef ...PMEM, breaking
compilation. And as PMEM is not in mainline, it seemed right to just
remove it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: drivers/video/msm: update to new kernel
Date: Thu, 12 Nov 2009 11:19:02 +0100 [thread overview]
Message-ID: <20091112101902.GA11980@elf.ucw.cz> (raw)
In-Reply-To: <20091103161733.970b885f.akpm@linux-foundation.org>
On Tue 2009-11-03 16:17:33, Andrew Morton wrote:
> On Thu, 22 Oct 2009 10:56:39 +0200
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > TASK_INTERRUPTIBLE and friends are now only available after including
> > <linux/sched.h>, so include it when needed.
> >
> > bus_id is no longer available/neccessary, so remove that.
> >
> > Android pmem driver is not available in mainline, so remove its hooks
> > from drivers/video.
> >
>
> What is the impact of these changes?
>
> #2 looks like it's a build fix. #3 looks like it isn't a build fix.
> #1 is a mystery.
Well, it now compiles. #1... I guess something changed in arm headers
and explicit include of <linux/sched.h> became neccessary. #3 not all
usages of pmem were protected with #ifdef ...PMEM, breaking
compilation. And as PMEM is not in mainline, it seemed right to just
remove it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Arve Hj?nnev?g <arve@android.com>,
Brian Swetland <swetland@google.com>
Subject: Re: drivers/video/msm: update to new kernel
Date: Thu, 12 Nov 2009 11:19:02 +0100 [thread overview]
Message-ID: <20091112101902.GA11980@elf.ucw.cz> (raw)
In-Reply-To: <20091103161733.970b885f.akpm@linux-foundation.org>
On Tue 2009-11-03 16:17:33, Andrew Morton wrote:
> On Thu, 22 Oct 2009 10:56:39 +0200
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > TASK_INTERRUPTIBLE and friends are now only available after including
> > <linux/sched.h>, so include it when needed.
> >
> > bus_id is no longer available/neccessary, so remove that.
> >
> > Android pmem driver is not available in mainline, so remove its hooks
> > from drivers/video.
> >
>
> What is the impact of these changes?
>
> #2 looks like it's a build fix. #3 looks like it isn't a build fix.
> #1 is a mystery.
Well, it now compiles. #1... I guess something changed in arm headers
and explicit include of <linux/sched.h> became neccessary. #3 not all
usages of pmem were protected with #ifdef ...PMEM, breaking
compilation. And as PMEM is not in mainline, it seemed right to just
remove it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-11-12 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 8:56 drivers/video/msm: update to new kernel Pavel Machek
2009-10-22 8:56 ` Pavel Machek
2009-10-22 8:56 ` Pavel Machek
2009-11-04 0:17 ` Andrew Morton
2009-11-04 0:17 ` Andrew Morton
2009-11-04 0:17 ` Andrew Morton
2009-11-12 10:19 ` Pavel Machek [this message]
2009-11-12 10:19 ` Pavel Machek
2009-11-12 10:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091112101902.GA11980@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.