diff for duplicates of <20091112145314.GA24682@us.ibm.com> diff --git a/a/1.txt b/N1/1.txt index eae31e4..851901f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,8 +14,8 @@ Quoting James Morris (jmorris@namei.org): > > sbsec->flags &= ~SE_SBLABELSUPP; > > > > /* Special handling for sysfs. Is genfs but also has setxattr handler*/ -> > - if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs")) = 0) -> > + if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs") - 1) = 0) +> > - if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs")) == 0) +> > + if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs") - 1) == 0) > > sbsec->flags |= SE_SBLABELSUPP; > > Shouldn't this be a simple strcmp() ? diff --git a/a/content_digest b/N1/content_digest index b6f8542..2f5fd2e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0alpine.LRH.2.00.0911121857110.31071@tundra.namei.org\0" "From\0Serge E. Hallyn <serue@us.ibm.com>\0" "Subject\0Re: [PATCH 3/4] security/selinux: decrement sizeof size in strncmp\0" - "Date\0Thu, 12 Nov 2009 14:53:14 +0000\0" + "Date\0Thu, 12 Nov 2009 08:53:14 -0600\0" "To\0James Morris <jmorris@namei.org>\0" "Cc\0Julia Lawall <julia@diku.dk>" Stephen Smalley <sds@tycho.nsa.gov> @@ -28,8 +28,8 @@ "> > \t\tsbsec->flags &= ~SE_SBLABELSUPP;\n" "> > \n" "> > \t/* Special handling for sysfs. Is genfs but also has setxattr handler*/\n" - "> > -\tif (strncmp(sb->s_type->name, \"sysfs\", sizeof(\"sysfs\")) = 0)\n" - "> > +\tif (strncmp(sb->s_type->name, \"sysfs\", sizeof(\"sysfs\") - 1) = 0)\n" + "> > -\tif (strncmp(sb->s_type->name, \"sysfs\", sizeof(\"sysfs\")) == 0)\n" + "> > +\tif (strncmp(sb->s_type->name, \"sysfs\", sizeof(\"sysfs\") - 1) == 0)\n" "> > \t\tsbsec->flags |= SE_SBLABELSUPP;\n" "> \n" "> Shouldn't this be a simple strcmp() ?\n" @@ -43,4 +43,4 @@ "\n" -serge -b01f804d092a553daf76d85871ebba8981d5bf03dcd4e37057c1aa044c1359c9 +dc01a3a9580c1075956a6e0236fa34c645339285b81a0e2171e788fa28966be0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.