From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 3/4] Update the UNIX buffer restore code to match the new format saved in the image file Date: Thu, 12 Nov 2009 13:43:06 -0600 Message-ID: <20091112194306.GA28322@us.ibm.com> References: <1257878856-25520-1-git-send-email-danms@us.ibm.com> <1257878856-25520-4-git-send-email-danms@us.ibm.com> <20091111213851.GE8761@us.ibm.com> <87vdhgvi6b.fsf@caffeine.danplanet.com> <20091112021824.GA14646@us.ibm.com> <87k4xvvc5b.fsf@caffeine.danplanet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87k4xvvc5b.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Smith Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > SH> But so should check whether h->len_len < sysctl_wmem_max before > SH> doing the capable check? Remember that any check for capable() > SH> will set PF_SUPERPRIV on the task, so it's better to not call it > SH> if it wasn't definately needed. > > Okay, sure. Ok, thanks - I figured if I was misunderstanding, then this suggestion would sound ridiculous and you'd suitably ridicule me :) thanks, -serge