From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N8gdT-0003f6-He for mharc-grub-devel@gnu.org; Thu, 12 Nov 2009 15:51:19 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8gdR-0003e4-Mc for grub-devel@gnu.org; Thu, 12 Nov 2009 15:51:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8gdN-0003bX-4E for grub-devel@gnu.org; Thu, 12 Nov 2009 15:51:17 -0500 Received: from [199.232.76.173] (port=48048 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8gdM-0003bP-Li for grub-devel@gnu.org; Thu, 12 Nov 2009 15:51:12 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:39495 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N8gdM-0007x7-BW for grub-devel@gnu.org; Thu, 12 Nov 2009 15:51:12 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1N8gdK-0003f4-0d for grub-devel@gnu.org; Thu, 12 Nov 2009 21:51:10 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1N8gdJ-0008Tr-6q for grub-devel@gnu.org; Thu, 12 Nov 2009 21:51:09 +0100 Date: Thu, 12 Nov 2009 21:51:09 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091112205109.GA32586@thorin> References: <1258058194.4779.6.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1258058194.4779.6.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Re: Bug in read_handler_list (autoloading) ??? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2009 20:51:17 -0000 Nice work. On Thu, Nov 12, 2009 at 09:36:34PM +0100, Felix Zielcke wrote: > /* Override previous handler.lst. */ > - while (grub_handler_class_list) > + for (; hc ; hc = hcnext) > { > - grub_handler_class_t tmp; > - tmp = grub_handler_class_list->next; > - grub_free (grub_handler_class_list); > - grub_handler_class_list = tmp; > + hcnext = hc->next; > + hl = hc->handler_list; > + while (hl) > + { > + grub_handler_t tmp = hl->next; > + if (grub_strcmp (hl->name, "rescue") != 0 > + && grub_strcmp (hl->name, "console") != 0) Could you add a comment here explaining why these are skipped? The rest is OK as far as I'm concerned. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."