All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>, mjevans1983@gmail.com
Subject: Re: [PATCH] resize2fs: exit fix_sb_journal_backup early for external journal
Date: Thu, 12 Nov 2009 19:47:29 -0500	[thread overview]
Message-ID: <20091113004729.GC32122@mit.edu> (raw)
In-Reply-To: <4AF88220.90908@redhat.com>

On Mon, Nov 09, 2009 at 02:57:04PM -0600, Eric Sandeen wrote:
> Resizing a filesystem with an external journal fails when it tries
> to read inode 0:
> 
> # touch testfs
> # truncate testfs 1342177280
> # touch testjournal
> # truncate testjournal 134217728
> # mke2fs -O journal_dev testjournal 
> # losetup /dev/loop0 testjournal 
> # mkfs.ext4 -J device=/dev/loop0 testfs 127680
> # resize2fs testfs 
> resize2fs 1.41.9 (22-Aug-2009)
> Resizing the filesystem on testfs to 327680 (4k) blocks.
> resize2fs: Illegal inode number while trying to resize testfs
> Please run 'e2fsck -fy testfs' to fix the filesystem
> after the aborted resize operation.
> 
> I think the right, simple thing to do is just bail out early
> for an external journal here, as there are no backup blocks
> to update.
> 
> Reported-by: mjevans1983@gmail.com
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Thanks, applied to the e2fsprogs maint branch.

					- Ted

      parent reply	other threads:[~2009-11-13  2:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 20:57 [PATCH] resize2fs: exit fix_sb_journal_backup early for external journal Eric Sandeen
2009-11-10  3:54 ` Michael Evans
2009-11-11  5:25   ` Michael Evans
2009-11-11  5:42     ` Eric Sandeen
2009-11-11  6:18       ` Michael Evans
2009-11-13  0:47 ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113004729.GC32122@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mjevans1983@gmail.com \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.