All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [Patch 3/7] tabled: Reduce verbosity in CLD client
Date: Fri, 13 Nov 2009 23:32:29 -0700	[thread overview]
Message-ID: <20091113233229.00da056a@redhat.com> (raw)

I got into habit of watching logs and there was too much useless
messaging in them. Some messages were stubs and reminders, so I left
them in the code, but commented out.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>

---
 server/cldu.c      |    9 ++-------
 server/storage.c   |    2 ++
 server/storparse.c |    5 +----
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/server/cldu.c b/server/cldu.c
index ea2266f..b48d86c 100644
--- a/server/cldu.c
+++ b/server/cldu.c
@@ -609,8 +609,8 @@ static int cldu_open_x_cb(struct cldc_call_opts *carg, enum cle_err_codes errc)
 		return 0;
 	}
 
-	if (debugging)
-		applog(LOG_DEBUG, "CLD directory \"%s\" opened", sp->xfname);
+	// if (debugging)
+	// 	applog(LOG_DEBUG, "CLD directory \"%s\" opened", sp->xfname);
 
 	/*
 	 * Read the directory.
@@ -713,9 +713,6 @@ static void next_chunk(struct cld_session *sp)
 	}
 	sp->yfname = mem;
 
-	if (debugging)
-		applog(LOG_DEBUG, "opening chunk parameters %s", sp->yfname);
-
 	memset(&copts, 0, sizeof(copts));
 	copts.cb = cldu_open_y_cb;
 	copts.private = sp;
@@ -780,8 +777,6 @@ static int cldu_get_y_cb(struct cldc_call_opts *carg, enum cle_err_codes errc)
 
 	ptr = carg->u.get.buf;
 	len = carg->u.get.size;
-	if (debugging)
-		applog(LOG_DEBUG, "got %d bytes from %s", len, sp->yfname);
 	stor_parse(sp->yfname, ptr, len);
 
 close_and_next:
diff --git a/server/storage.c b/server/storage.c
index e1368a6..f1822f7 100644
--- a/server/storage.c
+++ b/server/storage.c
@@ -387,6 +387,7 @@ static int stor_add_node_addr(struct storage_node *sn,
 		sn->addr_af = res->ai_family;
 		sn->alen = res->ai_addrlen;
 
+#if 0
 		if (debugging) {
 			char nhost[41];
 			char nport[6];
@@ -400,6 +401,7 @@ static int stor_add_node_addr(struct storage_node *sn,
 				applog(LOG_INFO, "Found Chunk host");
 			}
 		}
+#endif
 
 		/* Use just the first address for now. */
 		freeaddrinfo(res0);
diff --git a/server/storparse.c b/server/storparse.c
index d1c43a9..25841d2 100644
--- a/server/storparse.c
+++ b/server/storparse.c
@@ -145,7 +145,7 @@ static void cfg_elm_end_geo(struct config_context *cc)
 	}
 
 	if (!cc->loc.rack) {
-		applog(LOG_WARNING, "%s: No rack in Geo element", cc->fname);
+		// applog(LOG_WARNING, "%s: No rack in Geo element", cc->fname);
 		goto end;
 	}
 
@@ -389,9 +389,6 @@ void stor_parse(char *fname, const char *text, size_t len)
 		applog(LOG_WARNING, "%s: No useable Socket clause", fname);
 		goto out_free_all;
 	}
-	if (debugging)
-		applog(LOG_DEBUG, "Adding NID %u host %s port %s",
-		       ctx.nid, ctx.stor_ok_host, ctx.stor_ok_port);
 	stor_add_node(ctx.nid, ctx.stor_ok_host, ctx.stor_ok_port, &ctx.loc);
 
 out_free_all:

             reply	other threads:[~2009-11-14  6:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-14  6:32 Pete Zaitcev [this message]
2009-11-14  8:37 ` [Patch 3/7] tabled: Reduce verbosity in CLD client Jeff Garzik
2009-11-14 21:16   ` Pete Zaitcev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113233229.00da056a@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=hail-devel@vger.kernel.org \
    --cc=jeff@garzik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.