All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [Patch 7/7] tabled: Improve messages in storage.c
Date: Fri, 13 Nov 2009 23:37:09 -0700	[thread overview]
Message-ID: <20091113233709.7727ad32@redhat.com> (raw)

Mostly, add IDs so we can see which job and which node fails.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>

---
 server/storage.c |   16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/server/storage.c b/server/storage.c
index f1822f7..fdb3fc1 100644
--- a/server/storage.c
+++ b/server/storage.c
@@ -102,8 +102,9 @@ int stor_put_start(struct open_chunk *cep, void (*cb)(struct open_chunk *),
 	sprintf(stckey, stor_key_fmt, (unsigned long long) key);
 	if (!stc_put_startz(cep->stc, stckey, size, &cep->wfd, 0)) {
 		if (debugging)
-			applog(LOG_INFO, "stor put %s new for %lld error",
-			       stckey, (long long) size);
+			applog(LOG_INFO,
+			       "stor nid %u put %s new for %lld error",
+			       cep->node->id, stckey, (long long) size);
 		return -EIO;
 	}
 	cep->wtogo = size;
@@ -112,8 +113,8 @@ int stor_put_start(struct open_chunk *cep, void (*cb)(struct open_chunk *),
 	event_set(&cep->wevt, cep->wfd, EV_WRITE, stor_write_event, cep);
 
 	if (debugging)
-		applog(LOG_INFO, "stor put %s new for %lld",
-		       stckey, (long long) size);
+		applog(LOG_INFO, "stor nid %u put %s new for %lld",
+		       cep->node->id, stckey, (long long) size);
 
 	return 0;
 }
@@ -139,7 +140,8 @@ int stor_open_read(struct open_chunk *cep, void (*cb)(struct open_chunk *),
 	sprintf(stckey, stor_key_fmt, (unsigned long long) key);
 	if (!stc_get_startz(cep->stc, stckey, &cep->rfd, &size)) {
 		if (debugging)
-			applog(LOG_INFO, "stor put %s error", stckey);
+			applog(LOG_INFO, "stor nid %u get %s error",
+			       cep->node->id, stckey);
 		return -EIO;
 	}
 	*psize = size;
@@ -149,8 +151,8 @@ int stor_open_read(struct open_chunk *cep, void (*cb)(struct open_chunk *),
 	event_set(&cep->revt, cep->rfd, EV_READ, stor_read_event, cep);
 
 	if (debugging)
-		applog(LOG_INFO, "stor get %s size %lld",
-		       stckey, (long long) size);
+		applog(LOG_INFO, "stor nid %u get %s size %lld",
+		       cep->node->id, stckey, (long long) size);
 
 	return 0;
 }

             reply	other threads:[~2009-11-14  6:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-14  6:37 Pete Zaitcev [this message]
2009-11-14  8:40 ` [Patch 7/7] tabled: Improve messages in storage.c Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113233709.7727ad32@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=hail-devel@vger.kernel.org \
    --cc=jeff@garzik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.