From: Jakub Narebski <jnareb@gmail.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] gitweb: Refactor 'log' action generation, adding git_log_body()
Date: Sat, 14 Nov 2009 00:59:07 +0100 [thread overview]
Message-ID: <200911140059.08084.jnareb@gmail.com> (raw)
In-Reply-To: <20091114081050.6117@nanako3.lavabit.com>
On Sat, 14 Nov 2009, Nanako Shiraishi wrote:
> Quoting Jakub Narebski <jnareb@gmail.com>
>
> > Put the main part of 'log' view generation into git_log_body,
> > similarly how it is done for 'shortlog' and 'history' views (and
> > also for 'tags' and 'heads' views).
> >
> > This is preparation for extracting common code between 'log',
> > 'shortlog' and 'history' actions.
> >
> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> > ---
> > This is pure refactoring: output should change.
>
> Did you mean "should not change"?
Yes, of course, it should be "output should not change" (as opposed
to later patches, which unify not only code but some of looks).
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-11-13 23:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 1:02 [RFC/PATCH 0/3] gitweb: Refactor common parts of log-like views Jakub Narebski
2009-11-13 1:02 ` [PATCH 1/3] gitweb: Refactor 'log' action generation, adding git_log_body() Jakub Narebski
2009-11-13 23:10 ` Nanako Shiraishi
2009-11-13 23:59 ` Jakub Narebski [this message]
2009-11-13 1:02 ` [PATCH 2/3] gitweb: Refactor common parts of 'log' and 'shortlog' views Jakub Narebski
2009-11-13 1:02 ` [PATCH 3/3] gitweb: Make 'history' view (re)use git_log_generic() Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911140059.08084.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.