From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N9Kev-0002bS-Ps for mharc-grub-devel@gnu.org; Sat, 14 Nov 2009 10:35:29 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9Ket-0002ZF-JC for grub-devel@gnu.org; Sat, 14 Nov 2009 10:35:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9Kep-0002YI-5C for grub-devel@gnu.org; Sat, 14 Nov 2009 10:35:27 -0500 Received: from [199.232.76.173] (port=60944 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9Keo-0002YF-Vs for grub-devel@gnu.org; Sat, 14 Nov 2009 10:35:23 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:42068 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N9Keo-0004Th-JM for grub-devel@gnu.org; Sat, 14 Nov 2009 10:35:22 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1N9Kem-0003Ci-6A for grub-devel@gnu.org; Sat, 14 Nov 2009 16:35:20 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1N9Kel-0002hc-Lh for grub-devel@gnu.org; Sat, 14 Nov 2009 16:35:19 +0100 Date: Sat, 14 Nov 2009 16:35:19 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091114153519.GA7084@thorin> References: <1258058194.4779.6.camel@fz.local> <4AFDE128.6050408@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AFDE128.6050408@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Re: Bug in read_handler_list (autoloading) ??? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2009 15:35:28 -0000 On Fri, Nov 13, 2009 at 11:43:52PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Felix Zielcke wrote: > > Am Donnerstag, den 12.11.2009, 21:46 +0530 schrieb BVK: > > > >> Valgrind log is attached. It also reported invalid free for the same place. > >> > >> BTW, valgrind is run as > >> > >> sudo valgrind -v --log-file=/tmp/valgrind.log ./grub-emu > >> > > > > Here's a grub-emu tested patch to fix this > > > > > > > Why are all handlers are removed on normal.mod unload? If user e.g. > relies on special terminal he may lose terminal completely. I would say > it's better not to touch already loaded modules. I temporarily unmerged > it from experimental. We can remerge it once issues are fixed Did you unmerge Felix' fix, or the original prefix move fix? My goal was to make command and file-system auto-completion not break when $prefix is changed. Handlers are not the important change in my initial patch, and if it's problematic it can be discarded IMO. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."