From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1N9p04-0004tG-MK
	for mharc-grub-devel@gnu.org; Sun, 15 Nov 2009 18:59:20 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N9p02-0004t3-VE
	for grub-devel@gnu.org; Sun, 15 Nov 2009 18:59:18 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N9ozw-0004ri-QO
	for grub-devel@gnu.org; Sun, 15 Nov 2009 18:59:17 -0500
Received: from [199.232.76.173] (port=33732 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N9ozw-0004rf-Na
	for grub-devel@gnu.org; Sun, 15 Nov 2009 18:59:12 -0500
Received: from xvm-190-8.ghst.net ([217.70.190.8]:36693 helo=aybabtu.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1N9ozv-0002UX-II
	for grub-devel@gnu.org; Sun, 15 Nov 2009 18:59:12 -0500
Received: from [192.168.10.10] (helo=thorin)
	by aybabtu.com with esmtp (Exim 4.69)
	(envelope-from <rmh@aybabtu.com>)
	id 1N9ozu-00008l-0I; Mon, 16 Nov 2009 00:59:10 +0100
Received: from rmh by thorin with local (Exim 4.69)
	(envelope-from <rmh@aybabtu.com>)
	id 1N9ozt-0003Md-66; Mon, 16 Nov 2009 00:59:09 +0100
Date: Mon, 16 Nov 2009 00:59:09 +0100
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Message-ID: <20091115235909.GA12905@thorin>
References: <20091115231355.GA11962@thorin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091115231355.GA11962@thorin>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.18 (2008-05-17)
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
Cc: Jordi Mallach <jordi@sindominio.net>,
	Carles Pina i Estany <carles@pina.cat>
Subject: Re: gettext in build system
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Nov 2009 23:59:19 -0000

On Mon, Nov 16, 2009 at 12:13:55AM +0100, Robert Millan wrote:
> +po/messages.pot: po/POTFILES
> +	xgettext --from-code=utf-8 --keyword=_ -f $< -o $@
> +
> +po/*.po: po/messages.pot
> +	msgmerge -U $@ po/messages.pot
> +
> +po/%.mo: po/%.po
> +	$(MKDIR_P) $$(dirname $@)
> +	msgfmt -c --statistics -o $@ $^

Obvious missing thing is that these should be autoconffed.

> +#define _(str) gettext(str)

And I'm not sure if this is the right place to define _.  Isn't there
a system-wide definition?

> +  textdomain ("grub");

What's the usual way to handle this?  TEXTDOMAIN macro?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."