From: David Miller <davem@davemloft.net>
To: vladz@broadcom.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [net-next] bnx2x: Handle Rx and Tx together in NAPI
Date: Mon, 16 Nov 2009 02:20:12 -0800 (PST) [thread overview]
Message-ID: <20091116.022012.81633492.davem@davemloft.net> (raw)
In-Reply-To: <1258365669.8392.3.camel@lb-tlvb-vladz.il.broadcom.com>
From: "Vladislav Zolotarov" <vladz@broadcom.com>
Date: Mon, 16 Nov 2009 12:01:09 +0200
> - Limit Tx work done in one iteration by the same number of packets as
> Rx in order to ensure both fair work load balancing relatively to other
> devices scheduled for NAPI on the local CPU and sane Tx/Rx skb resource
> management from single QP perspective.
You should not do this.
RX is several orders of magnitude more work than TX is. TX therefore
should not be charged against the NAPI polling quota.
Don't try to be different from other drivers unless you have detailed
performance numbers from various situations (local TCP flows _and_
routing) to justify it. :-)
All NAPI drivers ignore TX work when considering NAPI polling quotas
and you should too :-)
next prev parent reply other threads:[~2009-11-16 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 10:01 [net-next] bnx2x: Handle Rx and Tx together in NAPI Vladislav Zolotarov
2009-11-16 10:20 ` David Miller [this message]
2009-11-16 10:32 ` Kumar Gopalpet-B05799
2009-11-16 10:41 ` David Miller
2009-11-16 11:03 ` Kumar Gopalpet-B05799
2009-11-16 11:05 ` David Miller
2009-11-16 11:56 ` Kumar Gopalpet-B05799
2009-11-16 12:24 ` David Miller
2009-11-16 11:11 ` Vladislav Zolotarov
2009-11-16 11:24 ` David Miller
2009-11-16 14:47 ` Vladislav Zolotarov
-- strict thread matches above, loose matches on Subject: below --
2009-11-16 16:05 Vladislav Zolotarov
2009-11-17 12:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116.022012.81633492.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.