From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Curt Wohlgemuth <curtw@google.com>
Subject: Re: [PATCH] ext4: directory blocks must be treated as metadata by ext4_forget()
Date: Mon, 16 Nov 2009 12:31:46 +0530 [thread overview]
Message-ID: <20091116070146.GA8600@skywalker.linux.vnet.ibm.com> (raw)
In-Reply-To: <20091115204346.GE4323@mit.edu>
On Sun, Nov 15, 2009 at 03:43:46PM -0500, Theodore Tso wrote:
> On Sun, Nov 15, 2009 at 12:34:48PM +0530, Aneesh Kumar K.V wrote:
> >
> > I guess we need to make sure we call ext4_forget with correct
> > is_metadata values. I did the below patch. The xattr changes in the
> > patch should be split as a separate one. I am not sure why we do a
> > get_bh there.
>
> It doesn't hurt to call ext4_forget() with the correct values, but I
> figured it was easier just to make ext4_forget() DTRT thing by
> checking the inode type since it has access to i_mode. My patch
> didn't take into account symlinks, though. Good catch on your part.
May be you want to merge the ext4_remove_blocks changes also. That make
sure anybody reading code doesn't have to spent time in figuring out
why ext4_forget is called with metadata = 0 and ext4_free_blocks is called
with metadata = 1.
-aneesh
next prev parent reply other threads:[~2009-11-16 7:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 23:46 Dirent blocks leaking into data file blocks Curt Wohlgemuth
2009-11-14 23:29 ` Theodore Tso
2009-11-15 0:30 ` [PATCH] ext4: directory blocks must be treated as metadata by ext4_forget() Theodore Ts'o
2009-11-15 7:04 ` Aneesh Kumar K.V
2009-11-15 7:16 ` Aneesh Kumar K.V
2009-11-15 20:43 ` Theodore Tso
2009-11-15 20:48 ` [PATCH] ext4: ext4_forget() must treat directory or symlink blocks as metadata Theodore Ts'o
2009-11-15 23:48 ` [PATCH] ext4: directory blocks must be treated as metadata by ext4_forget() Curt Wohlgemuth
2009-11-16 7:01 ` Aneesh Kumar K.V [this message]
2009-11-16 13:56 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116070146.GA8600@skywalker.linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.