From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Alon Ziv <alonz@discretix.com>
Subject: Re: Bug in drivers/serial/of_serial.c?
Date: Mon, 16 Nov 2009 09:09:08 +0100 [thread overview]
Message-ID: <200911160909.08433.arnd@arndb.de> (raw)
In-Reply-To: <8B957E110B62714A84290A01A597805F05CA0AA0@Exchange.discretix.com>
On Sunday 15 November 2009, Alon Ziv wrote:
> *)PORT_16450, },
> - { .type = "serial", .compatible = "ns16550", .data = (void *)PORT_16550, },
> + { .type = "serial", .compatible = "ns16550", .data = (void *)PORT_16550A, },
Does not seem logical. If the device claims compatibility with ns16550, we should
not automatically assume it's an ns16550a. Why not add another line for
{ .type = "serial", .compatible = "ns16550a", .data = (void *)PORT_16550A, },
Arnd <><
next prev parent reply other threads:[~2009-11-16 8:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 9:30 Bug in drivers/serial/of_serial.c? Alon Ziv
2009-11-16 8:09 ` Arnd Bergmann [this message]
2009-11-19 12:47 ` Alon Ziv
2009-11-19 13:01 ` Arnd Bergmann
2009-11-19 13:32 ` Alon Ziv
2009-11-19 13:41 ` Arnd Bergmann
2009-11-19 13:49 ` Alon Ziv
2009-11-19 14:09 ` Arnd Bergmann
2009-11-19 14:09 ` Arnd Bergmann
2009-11-19 16:03 ` Greg KH
2009-11-19 16:03 ` Greg KH
2009-11-19 17:22 ` Stephen Neuendorffer
2009-11-19 17:33 ` Arnd Bergmann
2009-11-19 17:42 ` Stephen Neuendorffer
2009-11-20 21:58 ` Grant Likely
2009-11-20 22:11 ` John Linn
2009-11-21 7:51 ` Grant Likely
2009-11-21 19:45 ` Arnd Bergmann
2009-11-22 22:42 ` Grant Likely
2009-11-22 22:43 ` Grant Likely
2009-11-20 21:56 ` Grant Likely
[not found] ` <977C41F842E66D4CB2E41332313B615008FC3C2F@XSJ-EXCHVS1.xlnx.xilinx.com>
2009-11-19 17:36 ` John Linn
2009-11-19 17:20 ` Stephen Neuendorffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911160909.08433.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alonz@discretix.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.