From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: compile error with pvops and pcifront Date: Mon, 16 Nov 2009 09:39:29 -0500 Message-ID: <20091116143929.GA30967@phenom.dumpdata.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: James Harper Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Sun, Nov 15, 2009 at 04:24:02PM +1100, James Harper wrote: > > Either CONFIG_XEN_PCIDEV_FRONTEND should not be allowed to be a > module, > > or CONFIG_XEN_PCIDEV_FRONTEND_MODULE needs to be checked for like: > > > > diff --git a/arch/x86/include/asm/xen/pci.h > > b/arch/x86/include/asm/xen/pci.h > > index 6c022c8..7b99422 100644 > > --- a/arch/x86/include/asm/xen/pci.h > > +++ b/arch/x86/include/asm/xen/pci.h > > @@ -35,7 +35,9 @@ static inline int xen_setup_msi_irqs(struct pci_dev > > *dev, int nvec, int type) > > return -1; > > } > > #endif > > -#if defined(CONFIG_PCI_MSI) && defined(CONFIG_XEN_PCIDEV_FRONTEND) > > + > > +#if defined(CONFIG_PCI_MSI) && (defined(CONFIG_XEN_PCIDEV_FRONTEND) \ > > + || defined(CONFIG_XEN_PCIDEV_FRONTEND_MODULE)) > > /* Defined in drivers/pci/xen-pcifront.c */ > > int pci_frontend_enable_msi(struct pci_dev *dev, int **vectors); > > void pci_frontend_disable_msi(struct pci_dev *dev); > > > > linewrapping probably destroyed the patch but it should be obvious > what > > is wrong. > > > > That's still not enough though - I get a link failure after that. Can you e-mail me your whole .config file, please?