From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] Dont call msi_unmap_pirq() if did not enabled msi Date: Mon, 16 Nov 2009 10:26:53 -0500 Message-ID: <20091116152653.GA20333@phenom.dumpdata.com> References: <20091116120030.GA13803@joejin-pc.cn.oracle.com> <20091116151546.GC30967@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20091116151546.GC30967@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Joe Jin Cc: "Hackel, Kurt" , Jerry Yuanjiang Ou , Xen-devel , Keir Fraser , greg.marsden@oracle.com List-Id: xen-devel@lists.xenproject.org On Mon, Nov 16, 2009 at 10:15:46AM -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 16, 2009 at 08:00:30PM +0800, Joe Jin wrote: > > Hi, > > > > When device driver unload, it may call pci_disable_msi(), if msi did not > > enabled but do msi_unmap_pirq(), then later driver reload and without > > Where does that happen? That looks to be a driver bug as well. > > > msi, then will failed in request_irq() for irq_desc[irq]->chip valie is > > no_irq_chip. So when did not enable msi during driver initializing, then > > Won't that mean it is unusable? As in, you can't allocate an IRQ > to the device when the irq_desc[irq]->chip_value==no_irq_chip? Duh! I think I answered myself here and the answer is yes, otherwise you would not have hit this bug :-(