From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NA7gQ-0008Lt-Dg for mharc-grub-devel@gnu.org; Mon, 16 Nov 2009 14:56:18 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NA7gO-0008Jo-30 for grub-devel@gnu.org; Mon, 16 Nov 2009 14:56:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NA7gJ-0008Ea-8p for grub-devel@gnu.org; Mon, 16 Nov 2009 14:56:15 -0500 Received: from [199.232.76.173] (port=50663 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NA7gI-0008EE-Uo for grub-devel@gnu.org; Mon, 16 Nov 2009 14:56:10 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:51427 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NA7gI-0005BU-Cy for grub-devel@gnu.org; Mon, 16 Nov 2009 14:56:10 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NA7gF-0003vx-H0 for grub-devel@gnu.org; Mon, 16 Nov 2009 20:56:07 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NA7gE-0000m1-UE for grub-devel@gnu.org; Mon, 16 Nov 2009 20:56:06 +0100 Date: Mon, 16 Nov 2009 20:56:06 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091116195606.GA31886@thorin> References: <20091115231355.GA11962@thorin> <20091115235909.GA12905@thorin> <20091116190956.GB19781@nubol.oskuro.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091116190956.GB19781@nubol.oskuro.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: gettext in build system X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2009 19:56:16 -0000 On Mon, Nov 16, 2009 at 08:09:56PM +0100, Jordi Mallach wrote: > > Also, as something merely cosmetic, messages.pot could be $(PACKAGE).pot, > which is more common. Changed in my gettext branch. > > > +#define _(str) gettext(str) > > And I'm not sure if this is the right place to define _. Isn't there > > a system-wide definition? > > This, and others, sometimes go in a common .h to avoid duplication. Many > grub utilities are going to add this kind of stuff. I wonder where would we put this. Is there any convention? > > > + textdomain ("grub"); > > What's the usual way to handle this? TEXTDOMAIN macro? > > As Colin said, $PACKAGE is common. > I haven't tested this patch yet, but I'm not sure if a bindtextdomain() > call is needed here too. This requires LOCALEDIR. Should we add po.m4 in order to get this, or just define it ourselves? > The rest looks good, given there's no automake. We have aclocal now (in my branch). Is gettext.m4 usable to us? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."