All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [RFC][PATCH] Basic unit testing support for GRUB
Date: Mon, 16 Nov 2009 22:21:56 +0100	[thread overview]
Message-ID: <20091116212156.GA7599@thorin> (raw)
In-Reply-To: <d019d53c0911130945n7187640dj8a22e03f47494564@mail.gmail.com>

On Fri, Nov 13, 2009 at 11:15:41PM +0530, BVK wrote:
> Hi,
> 
> 
> Attached is the (experimental branch) patch for unit testing that I
> have in mind for GRUB.  Please let me know your comments.
> 
> It provides "make check" target which would build and execute test
> programs from "tests" directory.  We can write small programs to test
> specific functions in GRUB.  For example, attached patch has sample
> program comparing grub_sprintf behavior against standard sprintf
> output (from glibc).
> 
> Note that it currently has few gotchas, like using TARGET_CC instead
> of BUILD_CC, no support for XPASS, XFAIL tests, etc.

Some parts don't follow our coding style;  please check with indent(1)
utility, it should produce the right indentation.  Also, we use C-style
/**/ syntax for comments.

Ah, and could you include a ChangeLog entry?

Thank you!

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  reply	other threads:[~2009-11-16 21:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 17:45 [RFC][PATCH] Basic unit testing support for GRUB BVK
2009-11-16 21:21 ` Robert Millan [this message]
2009-11-23 15:16   ` BVK
2009-11-23 15:54     ` BVK
2009-11-25 16:34 ` Felix Zielcke
2009-12-03  3:38   ` BVK
2009-12-04  7:15     ` BVK

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091116212156.GA7599@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.