From: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nanako Shiraishi <nanako3@lavabit.com>, git@vger.kernel.org
Subject: Re: [PATCH] Doc: mention the crlf attribute in config autocrlf section
Date: Tue, 17 Nov 2009 00:43:31 -0700 [thread overview]
Message-ID: <20091117074330.GA2813@comcast.net> (raw)
In-Reply-To: <7v7htpirmy.fsf@alter.siamese.dyndns.org>
On Mon, Nov 16, 2009 at 10:37:09PM -0800, Junio C Hamano wrote:
> How about this? I didn't touch the patch text (other than dropping
> trailing whitespaces).
>
> commit ff68668695486b72b5f06146eddf85b70841088a
> Author: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
> Date: Sat Nov 14 11:35:00 2009 -0700
>
> core.autocrlf documentation: mention the crlf attribute
>
> The description of the configuration variable is obsolete and
> wrong (saying only file content is used), not just incomplete.
> It has used the attribute mechanism for a long time.
>
> The documentation of gitattributes mentions the core.autocrlf
> configuration variable in its description of crlf attribute.
> Refer to the gitattributes documentation from here as well.
>
> Signed-off-by: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Looks good. Sorry about the extra space in the patch text;
stripping it sounds good as well.
--
Matthew Ogilvie [mmogilvi_git@miniinfo.net]
prev parent reply other threads:[~2009-11-17 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 18:35 [PATCH] Doc: mention the crlf attribute in config autocrlf section Matthew Ogilvie
2009-11-16 10:50 ` Nanako Shiraishi
2009-11-17 3:59 ` Matthew Ogilvie
2009-11-17 6:37 ` Junio C Hamano
2009-11-17 7:43 ` Matthew Ogilvie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117074330.GA2813@comcast.net \
--to=mmogilvi_git@miniinfo.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.