From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NALcm-0004LT-G1 for mharc-grub-devel@gnu.org; Tue, 17 Nov 2009 05:49:28 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NALck-0004Je-3C for grub-devel@gnu.org; Tue, 17 Nov 2009 05:49:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NALcf-0004Fx-4J for grub-devel@gnu.org; Tue, 17 Nov 2009 05:49:25 -0500 Received: from [199.232.76.173] (port=35053 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NALce-0004FR-PK for grub-devel@gnu.org; Tue, 17 Nov 2009 05:49:20 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:50006 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NALce-0003d4-Ea for grub-devel@gnu.org; Tue, 17 Nov 2009 05:49:20 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NALcb-0006Nz-Ko for grub-devel@gnu.org; Tue, 17 Nov 2009 11:49:17 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NALcb-00043J-0h for grub-devel@gnu.org; Tue, 17 Nov 2009 11:49:17 +0100 Date: Tue, 17 Nov 2009 11:49:17 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091117104917.GA18850@thorin> References: <20091115231355.GA11962@thorin> <20091115235909.GA12905@thorin> <20091116190956.GB19781@nubol.oskuro.net> <20091116195606.GA31886@thorin> <20091116223252.GA21513@nubol.oskuro.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091116223252.GA21513@nubol.oskuro.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: gettext in build system X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2009 10:49:26 -0000 On Mon, Nov 16, 2009 at 11:32:52PM +0100, Jordi Mallach wrote: > On Mon, Nov 16, 2009 at 08:56:06PM +0100, Robert Millan wrote: > > > > > +#define _(str) gettext(str) > > > > And I'm not sure if this is the right place to define _. Isn't there > > > > a system-wide definition? > > > This, and others, sometimes go in a common .h to avoid duplication. Many > > > grub utilities are going to add this kind of stuff. > > I wonder where would we put this. Is there any convention? > > I'm not aware of any convention, not even for GNU packages. nls.h, i18n.h, > grub-i18n.h. You name it. :) Ok. then. > > > I haven't tested this patch yet, but I'm not sure if a bindtextdomain() > > > call is needed here too. > > This requires LOCALEDIR. Should we add po.m4 in order to get this, or > > just define it ourselves? > > *shrug*, I think just assuming the usual $(datadir)/locale is ok. po.m4 > does provide checks for the gettext tools iirc, though, so that might > be useful in its own right. I enabled AM_GNU_GETTEXT() which drags that in, as well as a few of the other declarations we needed. Thanks! -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."