From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NAMLd-0005MG-I5
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:35:49 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NAMLY-0005K2-NN
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:35:49 -0500
Received: from [199.232.76.173] (port=58416 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NAMLY-0005Jt-Ab
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:35:44 -0500
Received: from verein.lst.de ([213.95.11.210]:42538)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1NAMLX-0002ul-4P
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:35:44 -0500
Date: Tue, 17 Nov 2009 12:35:41 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 07/15] scsi: add scsi-defs.h
Message-ID: <20091117113541.GG31958@lst.de>
References: <1258453071-3496-1-git-send-email-kraxel@redhat.com>
	<1258453071-3496-8-git-send-email-kraxel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1258453071-3496-8-git-send-email-kraxel@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Nov 17, 2009 at 11:17:43AM +0100, Gerd Hoffmann wrote:
> Largely based on <scsi/scsi.h> from linux.  Added into the tree so we
> can use the defines everywhere, not just in scsi-generic.c (which is
> linux-specific).

Btw, I'm not sure having the name clash with the Linux header is a good
idea as we need to include it for ioctls.  Also the complete lack of
prefixes for the defines might causes some problems.

Otherwise a good idea,


Reviewed-by: Christoph Hellwig <hch@lst.de>

> @@ -0,0 +1,156 @@
> +/* Copyright (C) 1998, 1999 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.

You probably want to take the kernel scsi.h to base things upon as it's
a lot more uptodate than the glibc one.