From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org,
David Brownell <dbrownell@users.sourceforge.net>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [RFC PATCH 1/5] Rework OpenFirmware GPIO handling
Date: Tue, 17 Nov 2009 19:12:44 +0300 [thread overview]
Message-ID: <20091117161244.GA6849@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1258472546-31343-2-git-send-email-dbaryshkov@gmail.com>
On Tue, Nov 17, 2009 at 06:42:22PM +0300, Dmitry Eremin-Solenikov wrote:
> This patch improves OF GPIO bindings so, that most non-OF-specific gpio
> controllers don't need to call any of OF binding function:
>
> 0) Move of_gpio_chip into main gpio_chip structure.
> 1) Call of_gpio_init/destroy from gpiochip_add/remove.
> 2) By default supply reasonable defaults for gpio_cells/xlate
Heh.. you didn't google before writing the code, did you? ;-)
I don't really think that David will like this approach, just as
he didn't like the previous one (which was even less intrusive,
but still wrong):
http://lkml.org/lkml/2008/10/16/248 (a huge thread, but worth reading)
Both of the approaches do not solve the pdata issue.
There are some of David's [absolutely legitimate] comments:
http://lkml.org/lkml/2008/10/20/43
Some more thoughts:
http://lkml.org/lkml/2008/10/20/182
And it turned out that the only sane solution is to write
OF-pdata-hooks for the each driver (that we do for many drivers
already):
http://lkml.org/lkml/2008/10/22/471
And for this, you'll need the patches that I sent to you
yesterday.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-11-17 16:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 15:42 [RFC 0/5] Rework OpenFirmware GPIO handling Dmitry Eremin-Solenikov
2009-11-17 15:42 ` [RFC PATCH 1/5] " Dmitry Eremin-Solenikov
2009-11-17 16:12 ` Anton Vorontsov [this message]
2009-11-17 20:08 ` Wolfram Sang
2009-11-17 20:08 ` Wolfram Sang
2009-11-17 20:18 ` Anton Vorontsov
2009-11-20 20:37 ` Grant Likely
2009-11-20 21:12 ` Grant Likely
2009-11-20 21:12 ` Grant Likely
2009-11-17 15:42 ` [RFC PATCH 2/5] mcu_mpc8349emitx: port to new of gpio interface Dmitry Eremin-Solenikov
2009-12-09 21:16 ` Kumar Gala
2009-12-09 21:16 ` Kumar Gala
2009-12-09 21:32 ` Anton Vorontsov
2009-11-17 15:42 ` [RFC PATCH 3/5] mpc8xxx_gpio: " Dmitry Eremin-Solenikov
2009-11-17 15:42 ` [RFC PATCH 4/5] simple_gpio: " Dmitry Eremin-Solenikov
2009-11-17 15:42 ` [RFC PATCH 5/5] qe_gpio: " Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117161244.GA6849@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.