Re: [net-next-2.6 PATCH 1/2] ethtool: Add PHY type to ethtool get_drvinfo

[Stephen Hemminger <shemminger@vyatta.com>]

On Tue, 17 Nov 2009 11:56:57 -0800 (Pacific Standard Time)
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com> wrote:

> On Tue, 17 Nov 2009, Stephen Hemminger wrote:
> 
> > On Tue, 17 Nov 2009 08:13:24 -0800
> > Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> > 
> > > From: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
> > > 
> > > Allow the PHY type to be passed from a driver to ethtool when
> > > ethtool -i ethX is called.  With newer network cards having SFP
> > > and SFP+ PHY cages, this information can be useful, especially
> > > if the NIC supports hot-swapping of the PHY modules.
> > > 
> > > Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > > ---
> > 
> > Maybe revive usage of connector port in ethtool rather than adding new API?
> > It is already there but values are out of date with current hardware.
> 
> You're referring to the MODE_GSET port settings?  If so, I like this 
> approach, and will update my patches accordingly.

Yes. cmd->port is always PORT_TP or PORT_FIBRE now but could be extended
Likewise cmd->transceiver could be modified.  I haven't seen an external transceiver
since the old fat yellow cable with vampire taps (and that was 20 yrs ago).