All of lore.kernel.org
 help / color / mirror / Atom feed
From: giometti@enneenne.com (Rodolfo Giometti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm pxa: remove "direction input" forcing for IRQ GPIOs
Date: Tue, 17 Nov 2009 19:02:00 +0100	[thread overview]
Message-ID: <20091117180200.GL4737@enneenne.com> (raw)
In-Reply-To: <20091117171116.GB14091@buzzloop.caiaq.de>

On Tue, Nov 17, 2009 at 06:11:16PM +0100, Daniel Mack wrote:
> On Tue, Nov 17, 2009 at 03:38:47PM +0100, Rodolfo Giometti wrote:
> > On Tue, Nov 17, 2009 at 02:06:53PM +0100, Daniel Mack wrote:
> > > On Tue, Nov 17, 2009 at 01:59:53PM +0100, Rodolfo Giometti wrote:
> > > > On Tue, Nov 17, 2009 at 01:43:34PM +0100, Daniel Mack wrote:
> > > 
> > > No, that's exactly my point. You don't need to set the pin to output
> > > direction to make use of those pull features. More than that, when
> > > confiugured as output, the pull flags actually don't make sense.
> > 
> > I just looking at pxa27x user manual but I don't see such pull-up
> > functionality... are you sure these settings aren't pxa3xx specific?
> > =:-o
> 
> I haven't checked the datasheet but the header files that defines this
> macro only. And it didn't appear to be PXA3x specific.

I cannot find such register nor pull-up/down management into whole
PXA27x user manual.

> Anyway, if this is unavailable on your hardware, the proper way would be
> to place an external resistor on the board (given that you can modify
> the schematics).

Why should I do as you suggest when the CPU can support such
electrical configuration?

> I'm still not convinced that driving the pad as output GPIO and then
> applying a different level externally to generate an IRQ is intended.

No external different level applyed! Just a pull-down enabled by a
machanical switch: if no cards are inserted I read 1 but if I insert a
card I got 0 due the pull-down enabling.

I tested the code on my hardware who works perfectly.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti at enneenne.com
Linux Device Driver                          giometti at linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

  reply	other threads:[~2009-11-17 18:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 11:21 [PATCH] arm pxa: remove "direction input" forcing for IRQ GPIOs Rodolfo Giometti
2009-11-17 11:44 ` Daniel Mack
2009-11-17 12:05   ` Rodolfo Giometti
2009-11-17 12:12     ` Eric Miao
2009-11-17 12:34     ` Daniel Mack
2009-11-17 12:37       ` Rodolfo Giometti
2009-11-17 12:43         ` Daniel Mack
2009-11-17 12:59           ` Rodolfo Giometti
2009-11-17 13:06             ` Daniel Mack
2009-11-17 13:16               ` Rodolfo Giometti
2009-11-17 14:38               ` Rodolfo Giometti
2009-11-17 17:11                 ` Daniel Mack
2009-11-17 18:02                   ` Rodolfo Giometti [this message]
2009-11-17 19:28                     ` Russell King - ARM Linux
2009-11-17 17:00   ` H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091117180200.GL4737@enneenne.com \
    --to=giometti@enneenne.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.