From: Dave Jones <davej@redhat.com>
To: Alex Chiang <achiang@hp.com>
Cc: Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH 2/3] ACPI: do not define acpi_processor_get_bios_limit() in processor.h
Date: Tue, 17 Nov 2009 19:09:09 -0500 [thread overview]
Message-ID: <20091118000909.GB1855@redhat.com> (raw)
In-Reply-To: <20091117221125.25933.71150.stgit@bob.kio>
On Tue, Nov 17, 2009 at 03:11:25PM -0700, Alex Chiang wrote:
> If we provide a definition for acpi_processor_get_bios_limit(), we will
> encounter build errors (multiple definitions of the function) when we
> do not have CONFIG_CPU_FREQ configured.
>
> We've already changed the modules that depend on this function to only
> get built when CONFIG_CPU_FREQ is configured, so removing the definition
> when unconfigured is safe.
>
> Cc: Thomas Renninger <trenn@suse.de>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Alex Chiang <achiang@hp.com>
> ---
>
> include/acpi/processor.h | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
There's 2-3 other fixes pending for the bios_limit patch.
For now, I've dropped it from cpufreq.next, until Thomas sends
a rediffed version with the compilation problems fixed.
Dave
next prev parent reply other threads:[~2009-11-18 0:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 22:11 [PATCH 0/3] cpufreq / linux-next build fixes Alex Chiang
2009-11-17 22:11 ` [PATCH 1/3] [CPUFREQ] make ACPI P-state cpufreq drivers depend on CONFIG_CPU_FREQ Alex Chiang
2009-11-18 0:08 ` Dave Jones
2009-11-18 4:17 ` Alex Chiang
2009-11-17 22:11 ` [PATCH 2/3] ACPI: do not define acpi_processor_get_bios_limit() in processor.h Alex Chiang
2009-11-18 0:09 ` Dave Jones [this message]
2009-11-19 11:31 ` [PATCH] ACPI: do not define acpi_processor_get_bios_limit() in processor.h (snd ver) Thomas Renninger
2009-11-19 18:08 ` Alex Chiang
2009-11-17 22:11 ` [PATCH 3/3] [CPUFREQ] make internal cpufreq_add_dev_* static Alex Chiang
2009-11-18 0:29 ` Dave Jones
2009-11-18 3:27 ` [PATCH v2] " Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118000909.GB1855@redhat.com \
--to=davej@redhat.com \
--cc=achiang@hp.com \
--cc=cpufreq@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.