From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
Sukadev Bhattiprolu
<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH 3/9] user-cr: s390 eclone wrapper
Date: Tue, 17 Nov 2009 21:23:33 -0600 [thread overview]
Message-ID: <20091118032333.GA18641@us.ibm.com> (raw)
In-Reply-To: <1258505746-31182-4-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org):
> Based on original work from Serge Hallyn.
Needed the following patch on top of that. Otherwise the
whole set looks good to me, thanks!
(Oh, one other note, the default #ifdef for NR_eclone actually
is different depending on whether we're on a c/r kernel or not,
unfortunately :(. I'm leaving it as the non-c/r kernel value
for now.)
thanks,
-serge
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 1/1] a few bugfixes for s390
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
clone_s390x.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/clone_s390x.c b/clone_s390x.c
index af3d41f..64d4436 100644
--- a/clone_s390x.c
+++ b/clone_s390x.c
@@ -34,7 +34,7 @@ typedef unsigned long long u64;
#define do_eclone(flags, pids, args, sz) \
( { \
- register unsigned long int __r1 asm ("1") = (unsigned long int)(__NR_eclone);
+ register unsigned long int __r1 asm ("1") = (unsigned long int)(__NR_eclone); \
register unsigned long int __r2 asm ("2") = (unsigned long int)(flags); \
register unsigned long int __r3 asm ("3") = (unsigned long int)(args); \
register unsigned long int __r4 asm ("4") = (unsigned long int)(sz); \
@@ -77,9 +77,10 @@ int eclone(int (*fn)(void *), void *fn_arg, int clone_flags_low,
my_args.child_stack = (unsigned long)child_sp;
my_args.child_stack_size = 0;
- rc = do_eclone(flags, pids, &my_args, sizeof(struct clone_args));
+ rc = do_eclone(clone_flags_low, pids, &my_args,
+ sizeof(struct clone_args));
if (rc < 0) {
- errno = rc;
+ errno = -rc;
rc = -1;
}
--
1.6.1.1
next prev parent reply other threads:[~2009-11-18 3:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 0:55 [PATCH 0/9] user-cr: update to eclone API; add nsexeccwp Nathan Lynch
[not found] ` <1258505746-31182-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-11-18 0:55 ` [PATCH 1/9] user-cr: add eclone/clone_args header Nathan Lynch
2009-11-18 0:55 ` [PATCH 2/9] user-cr: x86_32 eclone wrapper Nathan Lynch
2009-11-18 0:55 ` [PATCH 3/9] user-cr: s390 " Nathan Lynch
[not found] ` <1258505746-31182-4-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-11-18 3:23 ` Serge E. Hallyn [this message]
[not found] ` <20091118032333.GA18641-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-18 5:09 ` Nathan Lynch
[not found] ` <1258520988.4031.1254.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-11-18 15:24 ` Serge E. Hallyn
[not found] ` <20091118152450.GB23694-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-25 18:40 ` Oren Laadan
2009-11-18 0:55 ` [PATCH 4/9] user-cr: ppc32 " Nathan Lynch
[not found] ` <1258505746-31182-5-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-11-19 16:18 ` Nathan Lynch
2009-11-18 0:55 ` [PATCH 5/9] user-cr: add nsexeccwp to test eclone Nathan Lynch
2009-11-18 0:55 ` [PATCH 6/9] user-cr: use eclone API for restart Nathan Lynch
2009-11-18 0:55 ` [PATCH 7/9] user-cr: remove x86_32 clone_with_pids Nathan Lynch
2009-11-18 0:55 ` [PATCH 8/9] user-cr: remove s390 clone_with_pids Nathan Lynch
2009-11-18 0:55 ` [PATCH 9/9] user-cr: remove powerpc clone_with_pids Nathan Lynch
2009-11-25 18:41 ` [PATCH 0/9] user-cr: update to eclone API; add nsexeccwp Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118032333.GA18641@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
--cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.