From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: <linux-fsdevel@vger.kernel.org>, Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 10/12] writeback: remove the always false bdi_cap_writeback_dirty() test
Date: Wed, 18 Nov 2009 16:26:58 +0800 [thread overview]
Message-ID: <20091118082846.719033780@intel.com> (raw)
In-Reply-To: 20091118082648.140755818@intel.com
[-- Attachment #1: writeback-remove-memory-bdi.patch --]
[-- Type: text/plain, Size: 1277 bytes --]
This is dead code because no bdi flush thread will be started for
!bdi_cap_writeback_dirty bdis.
CC: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
fs/fs-writeback.c | 18 ------------------
1 file changed, 18 deletions(-)
--- linux.orig/fs/fs-writeback.c 2009-11-18 16:25:51.000000000 +0800
+++ linux/fs/fs-writeback.c 2009-11-18 16:26:04.000000000 +0800
@@ -597,7 +597,6 @@ static void writeback_inodes_wb(struct b
struct writeback_control *wbc)
{
struct super_block *sb = wbc->sb, *pin_sb = NULL;
- const int is_blkdev_sb = sb_is_blkdev_sb(sb);
const unsigned long start = jiffies; /* livelock avoidance */
spin_lock(&inode_lock);
@@ -618,23 +617,6 @@ static void writeback_inodes_wb(struct b
continue;
}
- if (!bdi_cap_writeback_dirty(wb->bdi)) {
- redirty_tail(inode);
- if (is_blkdev_sb) {
- /*
- * Dirty memory-backed blockdev: the ramdisk
- * driver does this. Skip just this inode
- */
- continue;
- }
- /*
- * Dirty memory-backed inode against a filesystem other
- * than the kernel-internal bdev filesystem. Skip the
- * entire superblock.
- */
- break;
- }
-
if (inode->i_state & (I_NEW | I_WILL_FREE)) {
requeue_io(inode);
continue;
next prev parent reply other threads:[~2009-11-18 8:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 8:26 [PATCH 00/12] trivial writeback cleanups/fixes Wu Fengguang
2009-11-18 8:26 ` [PATCH 01/12] writeback: remove unused nonblocking and congestion checks Wu Fengguang
2009-11-18 8:26 ` [PATCH 02/12] writeback: remove unused nonblocking and congestion checks (write_cache_pages) Wu Fengguang
2009-11-18 8:26 ` [PATCH 03/12] writeback: remove unused nonblocking and congestion checks (pohmelfs) Wu Fengguang
2009-11-19 8:11 ` Wu Fengguang
2009-11-19 11:04 ` Evgeniy Polyakov
2009-11-20 1:53 ` Wu Fengguang
2009-11-21 11:23 ` Evgeniy Polyakov
2009-11-18 8:26 ` [PATCH 04/12] writeback: remove unused nonblocking and congestion checks (afs) Wu Fengguang
2009-11-19 8:09 ` Wu Fengguang
2009-11-19 16:51 ` David Howells
2009-11-18 8:26 ` [PATCH 05/12] writeback: remove unused nonblocking and congestion checks (cifs) Wu Fengguang
2009-11-18 8:26 ` [PATCH 06/12] writeback: remove unused nonblocking and congestion checks (gfs2) Wu Fengguang
2009-11-18 9:59 ` Steven Whitehouse
2009-11-18 9:59 ` Steven Whitehouse
2009-11-18 10:09 ` Wu Fengguang
2009-11-18 11:13 ` Steven Whitehouse
2009-11-18 11:13 ` Steven Whitehouse
2009-11-18 8:26 ` [PATCH 07/12] writeback: remove unused nonblocking and congestion checks (xfs) Wu Fengguang
2009-11-18 21:27 ` Dave Chinner
2009-11-19 8:05 ` Wu Fengguang
2009-11-20 7:24 ` Dave Chinner
2009-11-18 8:26 ` [PATCH 08/12] ext4: remove encountered_congestion trace Wu Fengguang
2009-11-24 16:18 ` tytso
2009-11-18 8:26 ` [PATCH 09/12] ext4: remove unused parameter wbc from __ext4_journalled_writepage() Wu Fengguang
2009-11-24 16:18 ` tytso
2009-11-18 8:26 ` Wu Fengguang [this message]
2009-11-18 8:26 ` [PATCH 11/12] writeback: introduce wbc.for_background Wu Fengguang
2009-11-18 8:27 ` [PATCH 12/12] bdi: use bdi_stat_sum() for more accurate debugfs stats Wu Fengguang
2009-11-18 10:38 ` Peter Zijlstra
2009-11-19 7:59 ` Wu Fengguang
2009-11-19 8:12 ` Peter Zijlstra
2009-11-19 8:17 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118082846.719033780@intel.com \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.