Re: patch_realtek: support Vaio Type G

[Mattia Dongili <malattia@linux.it>]

On Tue, Nov 17, 2009 at 12:21:17PM +0100, Takashi Iwai wrote:
> At Tue, 17 Nov 2009 20:15:37 +0900,
> Mattia Dongili wrote:
> > 
> > On Tue, Nov 17, 2009 at 07:40:12AM +0100, Takashi Iwai wrote:
> > > At Tue, 17 Nov 2009 07:47:56 +0900,
> > > Mattia Dongili wrote:
> > > > 
> > > > On Mon, Nov 16, 2009 at 03:42:03PM +0100, Takashi Iwai wrote:
...
> > > What about model=auto?
> > 
> > err hmmm... well it works! I thought that model=auto was the same as no
> > parameter at all so haven't tried it. Sorry about the noise.
> 
> Good to hear.  You are partly right -- the model=auto isn't always the
> default.  If a quirk is already defined in the driver, another model
> is picked up.
> 
> I guess the problem is that current quirk for your device doesn't work.
...
> The fix patch is below.  Could you test it without model option?
> 
> I think we can get rid of the fallback of model=sony-assamd since
> now model=auto works almost well as long as the BIOS pins are correct.

Great, this works fine for me, I can't speak for sony-assamd specific
models.
Feel free to ad my
Tested-by: Mattia Dongili <malattia@linux.it>
Thanks

> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ef7d210..ba339d7 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -11470,6 +11470,7 @@ static struct snd_pci_quirk alc262_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x104d, 0x9016, "Sony VAIO", ALC262_AUTO), /* dig-only */
>  	SND_PCI_QUIRK(0x104d, 0x9025, "Sony VAIO Z21MN", ALC262_TOSHIBA_S06),
>  	SND_PCI_QUIRK(0x104d, 0x9035, "Sony VAIO VGN-FW170J", ALC262_AUTO),
> +	SND_PCI_QUIRK(0x104d, 0x9047, "Sony VAIO Type G", ALC262_AUTO),
>  	SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO",
>  			   ALC262_SONY_ASSAMD),
>  	SND_PCI_QUIRK(0x1179, 0x0001, "Toshiba dynabook SS RX1",
-- 
mattia
:wq!