From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: Re: APIC rework Date: Wed, 18 Nov 2009 09:15:22 -0500 Message-ID: <20091118141522.GB15585@phenom.dumpdata.com> References: <4B023285.50702@goop.org> <706158FABBBA044BAD4FE898A02E4BC201CD3205FF@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC201CD3205FF@pdsmsx503.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Zhang, Xiantao" Cc: Jeremy Fitzhardinge , Xen-devel , "Han, Weidong" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Tue, Nov 17, 2009 at 08:46:19PM +0800, Zhang, Xiantao wrote: > Jeremy Fitzhardinge wrote: > > On 11/16/09 19:45, Keir Fraser wrote: > >> It's kind of a shame to need this though. Is there no way for the > >> hypervisor to work out automatically whether an older dom0 is > >> running? Or work out the trigger/level stuff for itself (after all > >> it parses the relevant bios tables just like dom0)? > > > > If Xen can set the interrupt triggering by itself, why would it ever > > need dom0 to do it? Couldn't it just preconfigure all the pins, and > > then wait for dom0 to provide/request the pirq<->evtchn mapping? > > > After reviewing the logic, I think we can use DOMID_SELF to identify new dom0. In linux-2.6.18 dom0, only qemu uses this hypercall for device assginment, so map->domid shouldn't be dom0. If old dom0/qemu with this hypercall, keeps the logic unchanged, and only change the logic for new dom0 when call into it. Attached the patch. What about privileged domains that are not domain 0? Won't that mess this up?