From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 3/4] Update the UNIX buffer restore code to match the new format saved in the image file Date: Wed, 18 Nov 2009 09:16:24 -0600 Message-ID: <20091118151624.GA23694@us.ibm.com> References: <1258471590-29768-1-git-send-email-danms@us.ibm.com> <1258471590-29768-4-git-send-email-danms@us.ibm.com> <20091118043920.GD19841@us.ibm.com> <876397vrf1.fsf@caffeine.danplanet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <876397vrf1.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Smith Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > sk-> sk_sndbuf = sysctl_wmem_max; > > SH> Again, should you check whether h->len_len < sysctl_wmem_max > SH> before doing the capable(CAP_NET_ADMIN)? The goal is to prevent > SH> setting PF_SUPERPRIV in task->flags if it wasn't absolutely > SH> necessary. > > Yes, I think we agreed that we should, I just wasn't going to fold > that into these other unrelated changes. I'll spin another small > patch for that right away. Ok, then Acked-by: Serge Hallyn to the combination thanks, -serge