All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5 1/4] add TI DA8xx support: DA8xx includes
Date: Wed, 18 Nov 2009 11:49:52 -0600	[thread overview]
Message-ID: <20091118174951.GA15341@loki.buserror.net> (raw)
In-Reply-To: <20091117230946.F0FEEF51B07@gemini.denx.de>

On Wed, Nov 18, 2009 at 12:09:46AM +0100, Wolfgang Denk wrote:
> In message <4AF9823C.8090803@gefanuc.com> you wrote:
> > Provides initial support for TI OMAP-L1x/DA8xx SoC devices.
> > See http://www.ti.com
> > 
> > The DA8xx devices are similar to DaVinci devices but have a differing
> > memory map and updated peripheral versions.
> > 
> > Signed-off-by: Nick Thompson <nick.thompson@gefanuc.com>
> > Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ...
> > +enum davinci_lpsc_ids {
> > +	DAVINCI_LPSC_TPCC = 0,
> > +	DAVINCI_LPSC_TPTC0,
> > +	DAVINCI_LPSC_TPTC1,
> > +	DAVINCI_LPSC_AEMIF,
> > +	DAVINCI_LPSC_SPI0,
> > +	DAVINCI_LPSC_MMC_SD,
[snip]
> > +	DAVINCI_LPSC_eQEP,
> > +	DAVINCI_LPSC_SCR_P0,
> > +	DAVINCI_LPSC_SCR_P1,
> > +	DAVINCI_LPSC_CR_P3,
> > +	DAVINCI_LPSC_L3_CBA_RAM
> > +};
> 
> Variable names must be lower case. Please fix.

I suspect the compiler would take issue if you tried to vary those
constants...

-Scott

      reply	other threads:[~2009-11-18 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 15:09 [U-Boot] [PATCH V5 1/4] add TI DA8xx support: DA8xx includes Nick Thompson
2009-11-12 16:33 ` Paulraj, Sandeep
2009-11-17 23:10   ` Wolfgang Denk
2009-11-17 23:14     ` Paulraj, Sandeep
2009-11-18  9:23     ` Nick Thompson
2009-11-18 22:42       ` Wolfgang Denk
2009-11-17 23:09 ` Wolfgang Denk
2009-11-18 17:49   ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118174951.GA15341@loki.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.