From: Arnd Bergmann <arnd@arndb.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Jamie Lokier" <jamie@shareable.org>,
"Jan Blunck" <jblunck@suse.de>,
linux-fsdevel@vger.kernel.org,
"Linux-Kernel Mailinglist" <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
jkacur@redhat.com, "Thomas Gleixner" <tglx@linutronix.de>,
"Christoph Hellwig" <hch@infradead.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/2] BKL: Remove BKL from default_llseek()
Date: Wed, 18 Nov 2009 19:06:59 +0100 [thread overview]
Message-ID: <200911181906.59367.arnd@arndb.de> (raw)
In-Reply-To: <20091118180044.3d5981bf@lxorguk.ukuu.org.uk>
On Wednesday 18 November 2009, Alan Cox wrote:
> > There are drivers touching f_pos in ioctl() methods, which is vaguely
> > reasonable. There are also driver touching it in their read()/write()
> > methods, which has no effect whatsoever.
>
> osst is the obvious offender. The ioctl ones like mtdchar seem to be
> broken but they have their own locking (or lack thereof) in there own
> lseek so its an internal proble,.
>
The other ones I found before giving up are drivers/s390/char/tape_char.c
and drivers/sbus/char/flash.c.
Arnd <><
next prev parent reply other threads:[~2009-11-18 18:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 16:07 [PATCH 1/2] BKL: Remove BKL from default_llseek() Jan Blunck
2009-11-18 16:07 ` [PATCH 2/2] BKL: Update documentation on llseek( \b) Jan Blunck
2009-11-18 16:07 ` Jan Blunck
2009-11-18 17:15 ` [PATCH 1/2] BKL: Remove BKL from default_llseek() Alan Cox
2009-11-18 17:27 ` Jamie Lokier
2009-11-18 17:33 ` Arnd Bergmann
2009-11-18 18:00 ` Alan Cox
2009-11-18 18:06 ` Arnd Bergmann [this message]
2009-11-18 18:14 ` Alan Cox
2009-11-18 19:17 ` Arnd Bergmann
2009-11-18 17:35 ` Oliver Neukum
2009-11-18 17:50 ` Jamie Lokier
2009-11-18 18:16 ` Alan Cox
2009-11-19 2:40 ` Jamie Lokier
2009-11-19 10:13 ` Alan Cox
2009-11-18 17:55 ` Alan Cox
2009-11-18 17:55 ` Jan Blunck
2009-11-18 17:53 ` Jan Blunck
2009-11-18 18:17 ` Alan Cox
2009-11-18 20:02 ` Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911181906.59367.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jamie@shareable.org \
--cc=jblunck@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.