All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: David Zeuthen <david@fubar.dk>,
	linux-kernel@vger.kernel.org, axboe@kernel.dk,
	linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] [RFC] Add support for uevents on block device idle
Date: Wed, 18 Nov 2009 19:53:42 +0000	[thread overview]
Message-ID: <20091118195342.GA13627@srcf.ucam.org> (raw)
In-Reply-To: <ac3eb2510911181147ufeacb58u5194b0e1e5fd86d6@mail.gmail.com>

On Wed, Nov 18, 2009 at 08:47:37PM +0100, Kay Sievers wrote:
> On Wed, Nov 18, 2009 at 20:40, Matthew Garrett <mjg@redhat.com> wrote:
> > On Wed, Nov 18, 2009 at 08:30:07PM +0100, Kay Sievers wrote:
> >
> >> Wouldn't it be good enough, if we add a file "idle_since" which
> >> contains the time of the actual disk idle time, and userspace can
> >> schedule a re-examination of that value at the actual end of the idle
> >> time it is looking for?
> >
> > That would require either polling or waking up a userspace application
> > on every disk access. Doing it in-kernel involves only a single timer
> > wakeup for every active/idle transition.
> 
> How would it? If you look for, like a 60 seconds timeout, and the file
> contains 20, you schedule a wakeup in 40 seconds. If the file after
> the 40 seconds contains 60, you reached your idle timeout exactly at
> that moment, if it's less, then you re-calculate and start from the
> beginning.

How is that not polling? You'll repeatedly read a file looking for a 
value that may never appear - imagine the case where you're waiting for 
60 seconds of idleness, but the disk always becomes active again after 
50.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: David Zeuthen <david@fubar.dk>,
	linux-kernel@vger.kernel.org, axboe@kernel.dk,
	linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] [RFC] Add support for uevents on block device idle changes
Date: Wed, 18 Nov 2009 19:53:42 +0000	[thread overview]
Message-ID: <20091118195342.GA13627@srcf.ucam.org> (raw)
In-Reply-To: <ac3eb2510911181147ufeacb58u5194b0e1e5fd86d6@mail.gmail.com>

On Wed, Nov 18, 2009 at 08:47:37PM +0100, Kay Sievers wrote:
> On Wed, Nov 18, 2009 at 20:40, Matthew Garrett <mjg@redhat.com> wrote:
> > On Wed, Nov 18, 2009 at 08:30:07PM +0100, Kay Sievers wrote:
> >
> >> Wouldn't it be good enough, if we add a file "idle_since" which
> >> contains the time of the actual disk idle time, and userspace can
> >> schedule a re-examination of that value at the actual end of the idle
> >> time it is looking for?
> >
> > That would require either polling or waking up a userspace application
> > on every disk access. Doing it in-kernel involves only a single timer
> > wakeup for every active/idle transition.
> 
> How would it? If you look for, like a 60 seconds timeout, and the file
> contains 20, you schedule a wakeup in 40 seconds. If the file after
> the 40 seconds contains 60, you reached your idle timeout exactly at
> that moment, if it's less, then you re-calculate and start from the
> beginning.

How is that not polling? You'll repeatedly read a file looking for a 
value that may never appear - imagine the case where you're waiting for 
60 seconds of idleness, but the disk always becomes active again after 
50.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2009-11-18 19:53 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 14:37 [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-17 14:37 ` Matthew Garrett
2009-11-17 15:55 ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-17 15:55   ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-17 16:09   ` [PATCH] [RFC] Add support for uevents on block device idle David Zeuthen
2009-11-17 16:09     ` [PATCH] [RFC] Add support for uevents on block device idle changes David Zeuthen
2009-11-17 18:57     ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-17 18:57       ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-18 19:30       ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-18 19:30         ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-18 19:40         ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-18 19:40           ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-18 19:47           ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-18 19:47             ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-18 19:53             ` Matthew Garrett [this message]
2009-11-18 19:53               ` Matthew Garrett
2009-11-18 20:03               ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-18 20:03                 ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-18 20:07                 ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-18 20:07                   ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-18 21:06                   ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-18 21:06                     ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-18 21:29                     ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-18 21:29                       ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-18 21:35                       ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-18 21:35                         ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-18 21:39                         ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-18 21:39                           ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-18 21:45                           ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-18 21:45                             ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-18 21:33                     ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-18 21:33                       ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-18 21:40                       ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-18 21:40                         ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-19 11:09                       ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-19 11:09                         ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-19 13:01                         ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-19 13:01                           ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-19 13:29                           ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-19 13:29                             ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-19 14:16                             ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-19 14:16                               ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-19 14:25                               ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-19 14:25                                 ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-19 14:30                                 ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-19 14:30                                   ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-19 14:34                                   ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-19 14:34                                     ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-19 14:48                                     ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-19 14:48                                       ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-19 15:00                                       ` [PATCH] [RFC] Add support for uevents on block device idle Kay Sievers
2009-11-19 15:00                                         ` [PATCH] [RFC] Add support for uevents on block device idle changes Kay Sievers
2009-11-20 20:29                                         ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-20 20:29                                           ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-22 23:37                   ` [PATCH] [RFC] Add support for uevents on block device idle Pavel Machek
2009-11-22 23:37                     ` [PATCH] [RFC] Add support for uevents on block device idle changes Pavel Machek
2009-11-23 14:12                     ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-23 14:12                       ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-23 14:17                     ` [PATCH] [RFC] Add support for uevents on block device idle Jens Axboe
2009-11-23 14:17                       ` [PATCH] [RFC] Add support for uevents on block device idle changes Jens Axboe
2009-11-23 14:25                       ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-23 14:25                         ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-23 14:31                         ` [PATCH] [RFC] Add support for uevents on block device idle Jens Axboe
2009-11-23 14:31                           ` [PATCH] [RFC] Add support for uevents on block device idle changes Jens Axboe
2009-11-23 14:42                           ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-23 14:42                             ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-11-23 19:50                             ` [PATCH] [RFC] Add support for uevents on block device idle Jens Axboe
2009-11-23 19:50                               ` [PATCH] [RFC] Add support for uevents on block device idle changes Jens Axboe
2009-11-23 19:54                               ` [PATCH] [RFC] Add support for uevents on block device idle Matthew Garrett
2009-11-23 19:54                                 ` [PATCH] [RFC] Add support for uevents on block device idle changes Matthew Garrett
2009-12-11 21:20                               ` [RFC] Add support for events " Matthew Garrett
2009-11-18 22:10 ` [PATCH] [RFC] Add support for uevents " Bartlomiej Zolnierkiewicz
2009-11-18 22:10   ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118195342.GA13627@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=axboe@kernel.dk \
    --cc=david@fubar.dk \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.