From: Chris Mason <chris.mason@oracle.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: btrfs: possible unit mismatch on the async_delalloc_pages limit
Date: Wed, 18 Nov 2009 17:04:30 -0500 [thread overview]
Message-ID: <20091118220430.GD3110@think> (raw)
In-Reply-To: <20091118085132.GA9049@localhost>
On Wed, Nov 18, 2009 at 04:51:32PM +0800, Wu Fengguang wrote:
> Hi Chris,
>
> I suspect the async_delalloc_pages limit checking in btrfs/inode.c
>
> atomic_read(&root->fs_info->async_delalloc_pages) < 5 * 1042 * 1024
>
> never evaluate to FALSE because 5M pages are 20GB which is super
> large. I tried to fix it with the following patch. I increased the
> limit a bit, however still worry that the "corrected" limit is too
> small to create some regressions.
>
> What do you think?
Thanks, I'll give this a shot here.
-chris
prev parent reply other threads:[~2009-11-18 22:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 8:51 btrfs: possible unit mismatch on the async_delalloc_pages limit Wu Fengguang
2009-11-18 22:04 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118220430.GD3110@think \
--to=chris.mason@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.