All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carles Pina i Estany <carles@pina.cat>
To: grub-devel@gnu.org
Subject: grub-mkrescue and hard links
Date: Thu, 19 Nov 2009 22:22:57 +0000	[thread overview]
Message-ID: <20091119222257.GA1189@pina.cat> (raw)

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]


Hello,

grub-mkrescue is trying to execute cp -dpRl (l for link). If the origin
and destination directories are in different file systems this fails.

We could do a symbolic link (-s), detect if it's in the same device,
etc. but I think that just copying is enough and this optimization could
have other problems (like some utilites doesn't follow symbolic links,
etc.)

Small patch attached.

-- 
Carles Pina i Estany
	http://pinux.info

[-- Attachment #2: grub-mkrescue-nolinks.patch --]
[-- Type: text/x-diff, Size: 349 bytes --]

=== modified file 'util/grub-mkrescue.in'
--- util/grub-mkrescue.in	2009-11-14 18:38:11 +0000
+++ util/grub-mkrescue.in	2009-11-19 22:17:36 +0000
@@ -121,7 +121,7 @@
 if [ "${source}" != "" ] ; then
     for d in ${source}; do
       echo "Processing $d"
-      cp -dpRl "${d}" ${iso9660_dir}/
+      cp -dpR "${d}" ${iso9660_dir}/
     done
 fi
 


[-- Attachment #3: ChangeLog-grub-mkrescue-nolink --]
[-- Type: text/plain, Size: 120 bytes --]

2009-11-19  Carles Pina i Estany <carles@pina.cat>

	* util/grub-mkrescue.in: copies the files instead of hard linking


             reply	other threads:[~2009-11-19 22:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 22:22 Carles Pina i Estany [this message]
2009-11-20 13:36 ` grub-mkrescue and hard links Robert Millan
2009-11-21  1:54   ` Carles Pina i Estany
2009-11-21 13:14     ` Robert Millan
2009-11-21 11:39   ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-11-21 11:50     ` Carles Pina i Estany
2009-11-21 13:25       ` Robert Millan
2009-11-21 13:24     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091119222257.GA1189@pina.cat \
    --to=carles@pina.cat \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.