From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Aguilar Pena, Leed" <leed.aguilar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] USB: twl4030: Enable USB regulators before enabling USB charging
Date: Fri, 20 Nov 2009 10:37:55 +0200 [thread overview]
Message-ID: <20091120083755.GC8387@nokia.com> (raw)
In-Reply-To: <23D0CDE7C386D144A4F26EB0F427F8C074CF85B0@dlee04.ent.ti.com>
On Thu, Nov 19, 2009 at 07:34:55PM +0100, ext Aguilar Pena, Leed wrote:
>For TWL family of power management ICs, USB charging works only
>when USB regulators are in enabled state: 3v1, 1v5, 1v8
>
>On a USB cable attach, twl4030_phy_resume(twl) function enables
>the regulators. Enable USB charging, only after all regulators
>are enabled.
>
>Its observed that enabling USB charging before regulators are
>enabled, causes USB charging to fail.
>
>Tested on: Zoom2: omap3430: ES3.1 + TWL5030
>Needs T2-MADC and T2-BCI drivers which are still not upstreamed.
>
>Signed-off-by: Moiz Sonasath <m-sonasath@ti.com>
>Signed-off-by: Leed Aguilar <leed.aguilar@ti.com>
>Acked-by: Vikram Pandita <vikram.pandita@ti.com>
>Acked-by: Anand Gadiyar <gadiyar@ti.com>
>Acked-by: Nishanth Menon <nm@ti.com>
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
this should go to linux-usb, please Cc Greg KH and David Brownell.
--
balbi
next prev parent reply other threads:[~2009-11-20 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 18:34 [PATCH] USB: twl4030: Enable USB regulators before enabling USB charging Aguilar Pena, Leed
2009-11-20 8:37 ` Felipe Balbi [this message]
2009-11-23 17:59 ` Tony Lindgren
2009-11-23 18:21 ` Gadiyar, Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120083755.GC8387@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=leed.aguilar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.