From: Stephen Hemminger <shemminger@vyatta.com>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: netdev@vger.kernel.org, davem@davemloft.net, davej@redhat.com,
romieu@fr.zoreil.com
Subject: Re: [PATCH 0/7] via-velocity performance fixes
Date: Fri, 20 Nov 2009 09:03:48 -0800 [thread overview]
Message-ID: <20091120090348.1e51e29e@nehalam> (raw)
In-Reply-To: <20091120160633.77b7aee0@marrow.netinsight.se>
On Fri, 20 Nov 2009 16:06:33 +0100
Simon Kagstrom <simon.kagstrom@netinsight.net> wrote:
> 1. Correct setting of skipped checksums (unsure about this). The
> mainline driver sets CHECKSUM_UNNECESSARY if this is an IP packet
> except if the TCP checksum is NOT ok.
>
> The VIA driver sets CHECKSUM_UNNECESSARY if this is an UDP/TCP
> packet except if the TCP checksum is not OK. The patch selects the
> VIA behavior.
This doesn't seem correct.
The mainline driver is already doing the correct thing.
The VIA driver would send packet
with known bad checksum up the stack with CHECKSUM_UNNECESSARY.
What is supposed to happen is:
Checksum good: set CHECKSUM_UNNECESSARY
bad: leave CHECKSUM_NONE
This is all documented in skbuff.h
--
next prev parent reply other threads:[~2009-11-20 17:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 15:06 [PATCH 0/7] via-velocity performance fixes Simon Kagstrom
2009-11-20 15:12 ` [PATCH 1/7] via-velocity: Correct setting of skipped checksums Simon Kagstrom
2009-11-20 17:36 ` David Miller
2009-11-20 15:12 ` [PATCH 2/7] via-velocity: Correct 64-byte alignment for rx buffers Simon Kagstrom
2009-11-20 15:12 ` [PATCH 3/7] via-velocity: Enable support for adaptive interrupt supression Simon Kagstrom
2009-11-20 17:05 ` Stephen Hemminger
2009-11-20 17:47 ` David Miller
2009-11-20 15:12 ` [PATCH 4/7] via-velocity: Implement NAPI support Simon Kagstrom
2009-11-20 17:35 ` David Miller
2009-11-20 15:12 ` [PATCH 5/7] via-velocity: Change DMA_LENGTH_DEF (from the VIA driver) Simon Kagstrom
2009-11-20 15:12 ` [PATCH 6/7] via-velocity: Re-enable the transmit scatter-gather support Simon Kagstrom
2009-11-20 15:12 ` [PATCH 7/7] via-velocity: Bump version Simon Kagstrom
2009-11-20 17:03 ` Stephen Hemminger [this message]
2009-11-23 13:39 ` [PATCH 0/7] via-velocity performance fixes Simon Kagstrom
2009-11-23 16:27 ` Stephen Hemminger
2009-11-23 14:27 ` [PATCH v2 " Simon Kagstrom
2009-11-23 14:30 ` [PATCH v2 1/7] via-velocity: Correct 64-byte alignment for rx buffers Simon Kagstrom
2009-11-23 14:31 ` [PATCH v2 2/7] via-velocity: Add ethtool interrupt coalescing support Simon Kagstrom
2009-11-23 14:31 ` [PATCH v2 3/7] via-velocity: Implement NAPI support Simon Kagstrom
2009-11-23 14:31 ` [PATCH v2 4/7] via-velocity: Change DMA_LENGTH_DEF (from the VIA driver) Simon Kagstrom
2009-11-23 14:31 ` [PATCH v2 5/7] via-velocity: Re-enable transmit scatter-gather support Simon Kagstrom
2009-11-23 18:52 ` David Miller
2009-11-25 8:22 ` [PATCH v3 " Simon Kagstrom
2009-11-25 23:37 ` David Miller
2009-11-26 7:36 ` Simon Kagstrom
2009-11-26 21:09 ` David Miller
2009-11-23 14:31 ` [PATCH v2 6/7] via-velocity: Set tx checksum from ethtool instead of module parameter Simon Kagstrom
2009-11-23 14:31 ` [PATCH v2 7/7] via-velocity: Bump version Simon Kagstrom
2009-11-24 20:13 ` [PATCH v2 0/7] via-velocity performance fixes David Miller
2009-11-25 7:39 ` Simon Kagstrom
2009-11-25 20:18 ` David Miller
2009-11-26 8:04 ` [PATCH v4 " Simon Kagstrom
2009-11-26 8:09 ` [PATCH v4 1/7] via-velocity: Correct 64-byte alignment for rx buffers Simon Kagstrom
2009-11-26 8:10 ` [PATCH v4 2/7] via-velocity: Add ethtool interrupt coalescing support Simon Kagstrom
2009-11-26 8:10 ` [PATCH v4 3/7] via-velocity: Implement NAPI support Simon Kagstrom
2009-11-26 8:10 ` [PATCH v4 4/7] via-velocity: Change DMA_LENGTH_DEF (from the VIA driver) Simon Kagstrom
2009-11-26 8:10 ` [PATCH v4 5/7] via-velocity: Re-enable transmit scatter-gather support Simon Kagstrom
2009-11-26 8:10 ` [PATCH v4 6/7] via-velocity: Set tx checksum from ethtool instead of module parameter Simon Kagstrom
2009-11-26 8:10 ` [PATCH v4 7/7] via-velocity: Bump version Simon Kagstrom
2009-11-26 23:52 ` [PATCH v4 0/7] via-velocity performance fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120090348.1e51e29e@nehalam \
--to=shemminger@vyatta.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.