From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758027AbZKSXxa (ORCPT ); Thu, 19 Nov 2009 18:53:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757889AbZKSXx3 (ORCPT ); Thu, 19 Nov 2009 18:53:29 -0500 Received: from ozlabs.org ([203.10.76.45]:32918 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757873AbZKSXx3 (ORCPT ); Thu, 19 Nov 2009 18:53:29 -0500 From: Rusty Russell To: Adam Litke Subject: Re: virtio: Add memory statistics reporting to the balloon driver (V3) Date: Fri, 20 Nov 2009 10:23:30 +1030 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic; KDE/4.3.2; i686; ; ) Cc: Anthony Liguori , qemu-devel@nongnu.org, Avi Kivity , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <1258643169.3464.3.camel@aglitke> <1258643945.3464.5.camel@aglitke> In-Reply-To: <1258643945.3464.5.camel@aglitke> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200911201023.30709.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Nov 2009 01:49:05 am Adam Litke wrote: > Rusty and Anthony, > If I've addressed all outstanding issues, please consider this patch for > inclusion. Thanks. > > Changes since V2: > - Increase stat field size to 64 bits > - Report all sizes in kb (not pages) Hi Adam, Looks like we're very close. A few minor things: Why k? Why not just do the simplest possible thing, and just report all stats as straight numbers, now we have 64 bits. > - Drop anon_pages stat and fix endianness conversion Please drop endianness conversion. > +struct virtio_balloon_stat > +{ > + __le16 tag; > + __le64 val; > +}; Let's not introduce padding as well; __attribute__((packed)) here please. Thanks, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBGos-0000IP-L0 for qemu-devel@nongnu.org; Thu, 19 Nov 2009 18:53:46 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBGon-0000FG-DD for qemu-devel@nongnu.org; Thu, 19 Nov 2009 18:53:45 -0500 Received: from [199.232.76.173] (port=45430 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBGon-0000F9-6O for qemu-devel@nongnu.org; Thu, 19 Nov 2009 18:53:41 -0500 Received: from ozlabs.org ([203.10.76.45]:51532) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBGom-0006mR-Em for qemu-devel@nongnu.org; Thu, 19 Nov 2009 18:53:40 -0500 From: Rusty Russell Date: Fri, 20 Nov 2009 10:23:30 +1030 References: <1258643169.3464.3.camel@aglitke> <1258643945.3464.5.camel@aglitke> In-Reply-To: <1258643945.3464.5.camel@aglitke> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200911201023.30709.rusty@rustcorp.com.au> Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Litke Cc: linux-kernel@vger.kernel.org, Anthony Liguori , virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org, Avi Kivity On Fri, 20 Nov 2009 01:49:05 am Adam Litke wrote: > Rusty and Anthony, > If I've addressed all outstanding issues, please consider this patch for > inclusion. Thanks. > > Changes since V2: > - Increase stat field size to 64 bits > - Report all sizes in kb (not pages) Hi Adam, Looks like we're very close. A few minor things: Why k? Why not just do the simplest possible thing, and just report all stats as straight numbers, now we have 64 bits. > - Drop anon_pages stat and fix endianness conversion Please drop endianness conversion. > +struct virtio_balloon_stat > +{ > + __le16 tag; > + __le64 val; > +}; Let's not introduce padding as well; __attribute__((packed)) here please. Thanks, Rusty.